Re: Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16742/#review31945 --- committed. please mark as submitted. - Vinod Kone On Jan. 15, 201

Re: Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16742/#review31938 --- Ship it! Ship It! - Vinod Kone On Jan. 15, 2014, 9:21 p.m., Jian

Re: Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16742/ --- (Updated Jan. 15, 2014, 1:21 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-15 Thread Jiang Yan Xu
> On Jan. 13, 2014, 9:48 a.m., Vinod Kone wrote: > > src/tests/mesos.cpp, lines 85-88 > > > > > > Why did you have to do this? It doesn't seem to describe what this > > method is doing. > > Jiang Yan Xu wrote: > I

Re: Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-15 Thread Vinod Kone
> On Jan. 13, 2014, 5:48 p.m., Vinod Kone wrote: > > src/master/master.hpp, lines 178-181 > > > > > > Doesn't look like these two needed to be pulled up? > > Jiang Yan Xu wrote: > Right, but just thought these thr

Re: Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-13 Thread Jiang Yan Xu
> On Jan. 13, 2014, 9:48 a.m., Vinod Kone wrote: > > src/master/master.hpp, lines 178-181 > > > > > > Doesn't look like these two needed to be pulled up? Right, but just thought these three were of similar nature and

Re: Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16742/#review31621 --- src/master/master.hpp

Re: Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16742/#review31443 --- Ship it! Looking forward to see the tests get sped up! src/master

Review Request 16742: Made StartMaster() wait for leader election result before returning.

2014-01-08 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16742/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: M