Re: Review Request 17255: Add observe endpoint to master.

2014-03-20 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/#review37941 --- src/master/master.cpp

Re: Review Request 17255: Add observe endpoint to master.

2014-03-20 Thread Charlie Carson
On March 20, 2014, 6:45 p.m., Dominic Hamon wrote: src/master/master.cpp, line 551 https://reviews.apache.org/r/17255/diff/4/?file=484418#file484418line551 Could you follow up with a fix for this? It should be bound to Http::stats, not roles. opened

Re: Review Request 17255: Add observe endpoint to master.

2014-02-13 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/ --- (Updated Feb. 13, 2014, 6:55 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17255: Add observe endpoint to master.

2014-02-10 Thread Charlie Carson
On Feb. 10, 2014, 7:10 a.m., Benjamin Hindman wrote: src/Makefile.am, line 848 https://reviews.apache.org/r/17255/diff/2/?file=456965#file456965line848 Maybe s/health_tests/observe_tests/ ... although I assume you want to add more tests beyond just the observe endpoint? Since we

Re: Review Request 17255: Add observe endpoint to master.

2014-02-10 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/ --- (Updated Feb. 11, 2014, 12:10 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17255: Add observe endpoint to master.

2014-02-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/#review34161 --- Ship it! Nice test. src/master/http.cpp

Re: Review Request 17255: Add observe endpoint to master.

2014-02-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/#review34049 --- Ship it! src/Makefile.am

Re: Review Request 17255: Add observe endpoint to master.

2014-02-09 Thread Benjamin Hindman
On Jan. 29, 2014, 3:26 a.m., Benjamin Hindman wrote: src/master/http.cpp, line 363 https://reviews.apache.org/r/17255/diff/1/?file=436254#file436254line363 Do you want to check for 'jsonp'? Charlie Carson wrote: I'm not opposed, but not 100% it's useful either. jsonp is

Re: Review Request 17255: Add observe endpoint to master.

2014-01-30 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/ --- (Updated Jan. 30, 2014, 10:13 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17255: Add observe endpoint to master.

2014-01-30 Thread Charlie Carson
On Jan. 29, 2014, 3:26 a.m., Benjamin Hindman wrote: src/master/http.cpp, line 297 https://reviews.apache.org/r/17255/diff/1/?file=436254#file436254line297 You guys have likely already discussed this, but 'monitor' or 'metric'? 1) snapping to koalabird, just so we don't need to

Re: Review Request 17255: Add observe endpoint to master.

2014-01-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/#review33087 --- Stoked to see a HELP included from the very beginning! In addition

Review Request 17255: Add observe endpoint to master.

2014-01-23 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17255/ --- Review request for mesos, Benjamin Hindman and Jeff Currier. Bugs: