Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-29 Thread Ben Mahler
On Jan. 29, 2014, 7:03 a.m., Benjamin Hindman wrote: src/tests/environment.cpp, line 243 https://reviews.apache.org/r/17305/diff/3/?file=453453#file453453line243 Another thought, what about getting the process tree instead and printing that if this process has children? That

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-29 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/ --- (Updated Jan. 29, 2014, 10:30 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/ --- (Updated Jan. 29, 2014, 3:39 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/#review33105 --- Ship it! src/tests/environment.cpp

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-27 Thread Ben Mahler
On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote: src/launcher/executor.cpp, line 298 https://reviews.apache.org/r/17305/diff/1/?file=447761#file447761line298 I think it makes sense to have a global reaper just like we do with statistics. Having multiple libprocess processes

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-27 Thread Benjamin Hindman
On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote: src/launcher/executor.cpp, line 298 https://reviews.apache.org/r/17305/diff/1/?file=447761#file447761line298 I think it makes sense to have a global reaper just like we do with statistics. Having multiple libprocess processes

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/ --- (Updated Jan. 27, 2014, 11:25 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-27 Thread Ben Mahler
On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote: src/launcher/executor.cpp, line 298 https://reviews.apache.org/r/17305/diff/1/?file=447761#file447761line298 I think it makes sense to have a global reaper just like we do with statistics. Having multiple libprocess processes

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-24 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/#review32725 --- Ship it! Ship It! - Ian Downes On Jan. 24, 2014, 7:05 a.m., Ben

Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/ --- Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. Bugs:

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

2014-01-23 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/#review32706 --- Ship it! src/launcher/executor.cpp