Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

> On May 6, 2014, 7:23 p.m., Vinod Kone wrote: > > src/launcher/fetcher.cpp, line 194 > > > > > > Some one mentioned this on the MesosJenkins GitHub yesterday. > > > > This check for executable no longer works

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/#review42343 --- src/launcher/fetcher.cpp

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/#review41508 --- I've submitted this since the outstanding issues can be dropped. Tom

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

> On April 25, 2014, 6:23 a.m., Benjamin Hindman wrote: > > This is great Tom, thanks for contributing! > > > > You commented on IRC that the format of MESOS_EXECUTOR_URIS is indeed a bit > > bizarre. It's an artifact of not having JSON/protobuf parsing when this > > code was originally writte

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/#review41504 --- Patch looks great! Reviews applied: [20674] All tests passed. - M

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/#review41485 --- Ship it! src/launcher/fetcher.cpp

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

> On April 25, 2014, 6:23 a.m., Benjamin Hindman wrote: > > This is great Tom, thanks for contributing! > > > > You commented on IRC that the format of MESOS_EXECUTOR_URIS is indeed a bit > > bizarre. It's an artifact of not having JSON/protobuf parsing when this > > code was originally writte

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

> On April 24, 2014, 7:09 p.m., Adam B wrote: > > src/launcher/fetcher.cpp, line 195 > > > > > > What if the [X|N] is left off the uri in MESOS_EXECUTOR_URIS (for those > > upgrading from old URI lists)? > > For s

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/ --- (Updated April 25, 2014, 6:28 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/#review41439 --- Ship it! This is great Tom, thanks for contributing! You commented

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/#review41423 --- Bad patch! Reviews applied: [20674] Failed command: git apply --in

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

> On April 24, 2014, 7:09 p.m., Adam B wrote: > > src/launcher/fetcher.cpp, line 195 > > > > > > What if the [X|N] is left off the uri in MESOS_EXECUTOR_URIS (for those > > upgrading from old URI lists)? > > For s

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/#review41371 --- Just a few comments on upgrading and handling when the new optional

Re: Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/ --- (Updated April 24, 2014, 6:53 p.m.) Review request for mesos, Benjamin Hindman,

Review Request 20674: Add a new boolean CommandInfo.URI.extract

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20674/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, Ian Downes, Niklas N