---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 31, 2014, 10:05 p.m.)
Review request for mesos.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated Aug. 1, 2014, 12:41 a.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated Aug. 1, 2014, 1:39 a.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated Aug. 1, 2014, 1:58 a.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review49319
---
Ship it!
Rad Thomas! Can you draft a note to the dev/user lists
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48974
---
Bad patch!
Reviews applied: [23224]
Failed command: ./bootstrap
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 29, 2014, 6:39 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 29, 2014, 6:47 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 29, 2014, 6:47 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 29, 2014, 6:48 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 28, 2014, 5:39 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 28, 2014, 5:40 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48813
---
Bad patch!
Reviews applied: [23224]
Failed command: git apply
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
Looks good Thomas, just a few cleanups and we'll get this committed!
Also, I still have a few questions regarding the naming/structure of the
modules. ;-)
In particular, if we didn't have a native component, would we still
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48480
---
Looks good Thomas, just a few cleanups and we'll get this
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
Looks good Thomas, just a few cleanups and we'll get this committed!
Also, I still have a few questions regarding the naming/structure of the
modules. ;-)
In particular, if we didn't have a native component, would we still
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
Looks good Thomas, just a few cleanups and we'll get this committed!
Also, I still have a few questions regarding the naming/structure of the
modules. ;-)
In particular, if we didn't have a native component, would we still
On July 24, 2014, 3:53 p.m., Benjamin Hindman wrote:
src/Makefile.am, lines 939-941
https://reviews.apache.org/r/23224/diff/9/?file=625487#file625487line939
Weird indenting here? -1 space maybe?
No, these are all dep targets for make. Is there a better syntax for this?
On July
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 8, 2014, 5:05 p.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47454
---
Bad patch!
Reviews applied: [23224]
Failed command: make -j3
On July 8, 2014, 5:20 p.m., Mesos ReviewBot wrote:
Bad patch!
Reviews applied: [23224]
Failed command: make -j3 distcheck
Error:
if test -d mesos-0.20.0; then find mesos-0.20.0 -type d ! -perm -200
-exec chmod u+w {} ';' rm -rf mesos-0.20.0 || { sleep 5 rm -rf
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 8, 2014, 5:58 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47461
---
Patch looks great!
Reviews applied: [23224]
All tests passed.
-
On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
src/Makefile.am, line 137
https://reviews.apache.org/r/23224/diff/1/?file=622309#file622309line137
i would love to see all protos contained here, including messages
protos. this will allow for the development of a pure python
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 3, 2014, 5:25 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47213
---
This seems to be missing the setup.py(.in)s from mesos.api,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47228
---
Bad patch!
Reviews applied: [23224]
Failed command: ./bootstrap
On July 2, 2014, 6:17 p.m., Brian Wickman wrote:
This seems to be missing the setup.py(.in)s from mesos.api, mesos.native,
mesos.protocol. Forget to git add?
Otherwise this is looking great!
Argh, how'd I miss those. Thanks!
- Thomas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 2, 2014, 8:46 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47235
---
Bad patch!
Reviews applied: [23224]
Failed command: make -j3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 2, 2014, 11:53 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review47259
---
thanks for doing this work. this will be a huge improvement going
On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
src/python/native/setup.py.in, line 29
https://reviews.apache.org/r/23224/diff/4/?file=623204#file623204line29
what's your philosophy on versioning here?
should we always require deps==version or just deps=major,major+1
On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
src/Makefile.am, line 137
https://reviews.apache.org/r/23224/diff/1/?file=622309#file622309line137
i would love to see all protos contained here, including messages
protos. this will allow for the development of a pure python
On July 3, 2014, 12:10 a.m., Brian Wickman wrote:
src/python/protocol/setup.py.in, line 27
https://reviews.apache.org/r/23224/diff/4/?file=623207#file623207line27
same here, to be conservative, might want protobuf=2.5.0,3
Good call.
On July 3, 2014, 12:10 a.m., Brian Wickman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 3, 2014, 12:46 a.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
Review request for mesos.
Bugs: MESOS-857
37 matches
Mail list logo
