Re: Review Request 25618: MESOS-1792: add os::shell with pluggable IO descriptors

2014-09-15 Thread Kamil Domanski
> On Sept. 15, 2014, 7:34 p.m., Ian Downes wrote: > > Drive by question: what does this offer that can't already be done with > > Subprocess? Form is path, vector of args and pipe/path/fd for in/out/err. Huh, I guess I should have familiarized myself a little bit more with the codebase before

Re: Review Request 25618: MESOS-1792: add os::shell with pluggable IO descriptors

2014-09-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/#review53360 --- Drive by question: what does this offer that can't already be done w

Re: Review Request 25618: MESOS-1792: add os::shell with pluggable IO descriptors

2014-09-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/#review53287 --- Patch looks great! Reviews applied: [25618] All tests passed. - M

Re: Review Request 25618: MESOS-1792: add os::shell with pluggable IO descriptors

2014-09-14 Thread Kamil Domanski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/ --- (Updated Sept. 14, 2014, 4:05 p.m.) Review request for mesos, Adam B, Benjamin

Review Request 25618: MESOS-1792: add os::shell with pluggable IO descriptors

2014-09-13 Thread Kamil Domanski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25618/ --- Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod Ko