Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-10-14 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/ --- (Updated Oct. 14, 2014, 1:31 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-10-14 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review56567 --- src/linux/cgroups.cpp

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-10-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/ --- (Updated Oct. 2, 2014, 11:29 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54553 --- Ship it! src/linux/cgroups.cpp

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54643 --- Ship it! lgtm modulo comments. - Vinod Kone On Sept. 23, 2014,

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-23 Thread Ian Downes
On Sept. 22, 2014, 12:12 p.m., Ben Mahler wrote: Why do you need this? Seems like one would only watch for cgroup emptiness when destroying a cgroup, in which case, why split emptiness waiting from a successful destroy? This is for use in conjunction with pid namespaces: we kill

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-23 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/ --- (Updated Sept. 23, 2014, 4:39 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54362 --- Ship it! Ship It! - Timothy Chen On Sept. 23, 2014, 11:39 p.m.,

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-23 Thread Ben Mahler
On Sept. 22, 2014, 7:12 p.m., Ben Mahler wrote: Why do you need this? Seems like one would only watch for cgroup emptiness when destroying a cgroup, in which case, why split emptiness waiting from a successful destroy? Ian Downes wrote: This is for use in conjunction with

Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos-git

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54166 --- src/linux/cgroups.cpp

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54170 --- Why do you need this? Seems like one would only watch for cgroup

Re: Review Request 25864: Add 'FutureNothing cgroups::empty()'.

2014-09-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25864/#review54211 --- Patch looks great! Reviews applied: [25864] All tests passed. -