---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review59461
---
Ship it!
Ship It!
- Timothy Chen
On Oct. 5, 2014, 7:16 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review57414
---
Ship it!
I think we should get this in and then iterate on it. At
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
(Updated Oct. 5, 2014, 7:16 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review55472
---
Patch looks great!
Reviews applied: [26069]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
(Updated Sept. 29, 2014, 9:10 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
(Updated Sept. 29, 2014, 6:33 p.m.)
Review request for mesos, Benjamin
On Sept. 29, 2014, 1:17 p.m., Benjamin Hindman wrote:
support/clang-format, line 6
https://reviews.apache.org/r/26069/diff/2/?file=708122#file708122line6
This is actually not good, since the '{' is not on a newline. I guess
this is just for checking the access modifier offset,
On Sept. 29, 2014, 6:17 a.m., Benjamin Hindman wrote:
How much fine-tuning can we apply here? Between this and cpplint.py will we
cover out style completely? Looking forward to helping make folks more
productive but don't want to frustrate people that use this and then still
get
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54884
---
Patch looks great!
Reviews applied: [26069]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
(Updated Sept. 26, 2014, 6:09 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54654
---
Patch looks great!
Reviews applied: [26069]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54700
---
.gitignore-template
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54707
---
.gitignore-template
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/#review54709
---
what version of clang-format does this expect? 3.5?
- Dominic
On Sept. 26, 2014, 5:48 p.m., Timothy Chen wrote:
.gitignore-template, line 27
https://reviews.apache.org/r/26069/diff/1/?file=705927#file705927line27
You're adding a .clang-format in the root folder but also git ignoring
it the same time. Will this file change on the fly?
Good
On Sept. 26, 2014, 6:31 p.m., Dominic Hamon wrote:
.gitignore-template, line 27
https://reviews.apache.org/r/26069/diff/1/?file=705927#file705927line27
i think it's better to put the contents of support/clang-format into
.clang-format and not ignore it.
How about keeping things
On Sept. 26, 2014, 6:31 p.m., Dominic Hamon wrote:
what version of clang-format does this expect? 3.5?
Yes. `clang-format-3.5` is expected.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
Review request for mesos, Benjamin Hindman, Cody Maloney, Dominic Hamon, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26069/
---
(Updated Sept. 26, 2014, 5:56 a.m.)
Review request for mesos, Benjamin
19 matches
Mail list logo
