Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-10-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/#review55156 --- Ship it! src/master/master.cpp

Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-10-01 Thread Benjamin Mahler
A bit worried that slave-resources() could be confused with slave-info.resources(). Maybe slave-allocated() feels better to you? Callers will have the type available at the call-site, since we have static typing to force them to understand what type is being returned: hashmapFrameworkID,

Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-10-01 Thread Vinod Kone
On Oct. 1, 2014, 11:05 p.m., Vinod Kone wrote: src/master/master.cpp, line 4293 https://reviews.apache.org/r/26199/diff/1/?file=709864#file709864line4293 hmmm. slave-used() doesn't really tell what is being returned here. how about calling it slave-resources() instead. do you

Review Request 26199: Eliminated redundant resource accounting in the master.

2014-09-30 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description

Re: Review Request 26199: Eliminated redundant resource accounting in the master.

2014-09-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26199/#review55037 --- Ship it! Ship It! - Timothy Chen On Sept. 30, 2014, 11:30 p.m.,