Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/ --- (Updated Oct. 10, 2014, 9:39 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Michael Park
> On Oct. 10, 2014, 6:02 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/process.cpp, line 2449 > > > > > > We usually prefer an explict representation: > > > > ``` > > if (ptr != nullptr) { > > } > >

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56192 --- 3rdparty/libprocess/include/process/process.hpp

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56186 --- Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56177 --- Ship it! LGTM. 3rdparty/libprocess/src/process.cpp

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56173 --- 3rdparty/libprocess/src/process.cpp

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56172 --- Ship it! Ship It! - Dominic Hamon On Oct. 9, 2014, 6:02 p.m., Jo

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Joris Van Remoortere
> On Oct. 10, 2014, 5:04 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/process.cpp, line 1453 > > > > > > should these be std::unique_ptr instead? (i'm currently adding support > > for this to the libprocess

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-10 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56166 --- 3rdparty/libprocess/src/process.cpp

Re: Review Request 26533: Memory cleanup: libprocess finalize

2014-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/#review56091 --- Patch looks great! Reviews applied: [26533] All tests passed. - M

Review Request 26533: Memory cleanup: libprocess finalize

2014-10-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26533/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository: meso