Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review58915 --- The GarbageCollector is one of the earliest libprocess processes

Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/ --- (Updated Oct. 22, 2014, 6:28 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review57870 --- Bad patch! Reviews applied: [26712, 26578, 26580, 26583] Failed

Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-14 Thread Niklas Nielsen
On Oct. 10, 2014, 5:15 p.m., Dominic Hamon wrote: 3rdparty/libprocess/src/process.cpp, line 1631 https://reviews.apache.org/r/26583/diff/1/?file=717970#file717970line1631 this can't land until https://reviews.apache.org/r/26289/ which contains the configure.ac check for

Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-14 Thread Dominic Hamon
On Oct. 10, 2014, 5:15 p.m., Dominic Hamon wrote: 3rdparty/libprocess/src/process.cpp, line 1631 https://reviews.apache.org/r/26583/diff/1/?file=717970#file717970line1631 this can't land until https://reviews.apache.org/r/26289/ which contains the configure.ac check for

Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-13 Thread Joris Van Remoortere
On Oct. 11, 2014, 12:15 a.m., Dominic Hamon wrote: 3rdparty/libprocess/src/process.cpp, line 1635 https://reviews.apache.org/r/26583/diff/1/?file=717970#file717970line1635 should do the same for this while you're here. Since help is covered by the garbage collector it doesn't make

Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository:

Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review56261 --- Bad patch! Reviews applied: [26578, 26580, 26583] Failed command:

Re: Review Request 26583: Memory cleanup: libprocess delete garbage collector process

2014-10-10 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26583/#review56262 --- 3rdparty/libprocess/src/process.cpp