Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-21 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/ --- (Updated Nov. 21, 2014, 1:29 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/#review62512 --- Patch looks great! Reviews applied: [26894] All tests passed. - M

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/#review62506 --- Ship it! Could you cleanup the includes before you commit? Ditto fo

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-20 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/ --- (Updated Nov. 20, 2014, 5:55 p.m.) Review request for mesos and Ben Mahler. B

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-20 Thread Niklas Nielsen
> On Nov. 20, 2014, 5:09 p.m., Ben Mahler wrote: > > src/tests/active_user_test_helper.cpp, lines 31-60 > > > > > > Curious, do we have to do all this Subprocess stuff with 'whoami' or > > can we just use os::user? > >

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-20 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/#review62478 --- src/tests/active_user_test_helper.cpp

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/#review62176 --- Patch looks great! Reviews applied: [26894] All tests passed. - M

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-19 Thread Niklas Nielsen
> On Oct. 18, 2014, 2:50 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 528 > > > > > > Hm.. this doesn't look like the right usage of shell=false (which > > should use the `arguments` field): > > >

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user.

2014-11-19 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/ --- (Updated Nov. 19, 2014, 8:53 a.m.) Review request for mesos and Ben Mahler. S

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user

2014-11-11 Thread Ben Mahler
> On Oct. 18, 2014, 9:50 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 528 > > > > > > Hm.. this doesn't look like the right usage of shell=false (which > > should use the `arguments` field): > > >

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user

2014-11-11 Thread Niklas Nielsen
> On Oct. 18, 2014, 2:50 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 528 > > > > > > Hm.. this doesn't look like the right usage of shell=false (which > > should use the `arguments` field): > > >

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user

2014-10-18 Thread R.B. Boyer
> On Oct. 18, 2014, 4:50 p.m., Ben Mahler wrote: > > src/tests/slave_tests.cpp, line 528 > > > > > > Hm.. this doesn't look like the right usage of shell=false (which > > should use the `arguments` field): > > >

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user

2014-10-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/#review57283 --- src/tests/slave_tests.cpp

Re: Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user

2014-10-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/#review57250 --- Patch looks great! Reviews applied: [26894] All tests passed. - M

Review Request 26894: Changed RunTaskWithCommandInfoWithUser to _not_ use shell with the nobody user

2014-10-17 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26894/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1359 https://issues.ap