Re: Review Request 27498: Abstract clock internals from ProcessManager::settle.

2014-11-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27498/ --- (Updated Nov. 14, 2014, 11:15 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 27498: Abstract clock internals from ProcessManager::settle.

2014-11-14 Thread Benjamin Hindman
On Nov. 11, 2014, 10:49 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/include/process/clock.hpp, line 8 https://reviews.apache.org/r/27498/diff/1/?file=747103#file747103line8 Where are you using Nothing()? Oops, thanks! On Nov. 11, 2014, 10:49 p.m., Niklas Nielsen wrote:

Re: Review Request 27498: Abstract clock internals from ProcessManager::settle.

2014-11-14 Thread Niklas Nielsen
On Nov. 11, 2014, 2:49 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/include/process/future.hpp, line 1139 https://reviews.apache.org/r/27498/diff/1/?file=747104#file747104line1139 Do you have an example of how that could happen? Benjamin Hindman wrote: I updated the

Re: Review Request 27498: Abstract clock internals from ProcessManager::settle.

2014-11-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27498/#review61553 --- Ship it! Ship It! - Niklas Nielsen On Nov. 14, 2014, 3:15 p.m.,

Re: Review Request 27498: Abstract clock internals from ProcessManager::settle.

2014-11-14 Thread Niklas Nielsen
On Nov. 11, 2014, 2:49 p.m., Niklas Nielsen wrote: It would be really helpful if we could put together a sequence chart of what can be going on during settle and what needs to get synchronized I'll go ahead and add a JIRA ticket for the documentation piece. - Niklas

Re: Review Request 27498: Abstract clock internals from ProcessManager::settle.

2014-11-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27498/ --- (Updated Nov. 11, 2014, 4:52 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 27498: Abstract clock internals from ProcessManager::settle.

2014-11-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27498/#review60852 --- It would be really helpful if we could put together a sequence