Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

2014-11-14 Thread Benjamin Hindman
On Nov. 12, 2014, 7:22 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/src/process.cpp, line 873 https://reviews.apache.org/r/27508/diff/1/?file=747126#file747126line873 Do you need both socket and s? Yes, but Joris upcoming reviews replace this, so I'm not going to cause him any

Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

2014-11-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27508/ --- (Updated Nov. 14, 2014, 11:18 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

2014-11-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27508/#review61592 --- Ship it! Ship It! - Niklas Nielsen On Nov. 14, 2014, 3:18 p.m.,

Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

2014-11-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27508/#review60671 --- 3rdparty/libprocess/src/process.cpp

Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

2014-11-12 Thread Joris Van Remoortere
On Nov. 12, 2014, 7:22 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/src/process.cpp, lines 1621-1624 https://reviews.apache.org/r/27508/diff/1/?file=747126#file747126line1621 This was called before regardless if connect succeeded or failed - this changed here, do you know why?

Re: Review Request 27508: Used io::poll instead of libev for ignore_data.

2014-11-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27508/ --- (Updated Nov. 11, 2014, 4:55 p.m.) Review request for mesos, Ben Mahler, Jie