Re: Review Request 27605: Add a unit test to stout path

2014-11-13 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27605/#review61292 --- Ship it! Thanks Cody! I changed the commit message slightly on thi

Re: Review Request 27605: Add a unit test to stout path

2014-11-13 Thread Ben Mahler
> On Nov. 10, 2014, 7:50 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, line 30 > > > > > > Is there a configure check for initializer lists? > > Cody Maloney wrote: > Not yet.

Re: Review Request 27605: Add a unit test to stout path

2014-11-12 Thread Cody Maloney
> On Nov. 10, 2014, 7:50 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, lines 27-29 > > > > > > What's the distinction between these three tests? Seems more like a > > test of impl

Re: Review Request 27605: Add a unit test to stout path

2014-11-12 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27605/ --- (Updated Nov. 13, 2014, 12:39 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 27605: Add a unit test to stout path

2014-11-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27605/#review60651 --- Thanks Cody! Sorry, I was waiting for the patch to be updated, didn

Re: Review Request 27605: Add a unit test to stout path

2014-11-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27605/#review59925 --- Bad patch! Reviews applied: [27605] Failed command: ./support/appl

Review Request 27605: Add a unit test to stout path

2014-11-04 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27605/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1733 and mesos-1877 ht