---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/
---
Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/#review61762
---
3rdparty/libprocess/include/process/socket.hpp
On Nov. 17, 2014, 6:49 p.m., Dominic Hamon wrote:
3rdparty/libprocess/include/process/socket.hpp, line 95
https://reviews.apache.org/r/28125/diff/1/?file=765990#file765990line95
why not just do the second version all the time?
Because making 1 system call instead of 3 is preferred.
On Nov. 17, 2014, 10:49 a.m., Dominic Hamon wrote:
3rdparty/libprocess/include/process/socket.hpp, line 95
https://reviews.apache.org/r/28125/diff/1/?file=765990#file765990line95
why not just do the second version all the time?
Joris Van Remoortere wrote:
Because making 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/#review61768
---
Thanks Joris! Feel free to have someone just get this committed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/#review61773
---
Ship it!
LGTM modulo Ben's comment
We could think about making
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/
---
(Updated Nov. 17, 2014, 7:06 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/#review61775
---
Ship it!
Looks great!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/
---
(Updated Nov. 17, 2014, 7:26 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28125/#review61785
---
Patch looks great!
Reviews applied: [28125]
All tests passed.
-
10 matches
Mail list logo
