Re: Review Request 31503: (2/4) Add the Classifier action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review74856 --- src/tests/routing_tests.cpp

Re: Review Request 31503: (2/4) Add the Classifier action

> On March 2, 2015, 9:36 p.m., Chi Zhang wrote: > > src/tests/routing_tests.cpp, line 446 > > > > > > If you can have a way to programmatically determine the existence of > > this condition, this test should be checke

Re: Review Request 31503: (2/4) Add the Classifier action

> On March 2, 2015, 9:36 p.m., Chi Zhang wrote: > > src/tests/routing_tests.cpp, line 446 > > > > > > If you can have a way to programmatically determine the existence of > > this condition, this test should be checke

Re: Review Request 31503: (2/4) Add the Classifier action

> On March 2, 2015, 9:36 p.m., Chi Zhang wrote: > > src/linux/routing/filter/internal.hpp, line 274 > > > > > > The function comment looks like you are not doing anything with any > > non-u32 filters but returning err

Re: Review Request 31503: (2/4) Add the Classifier action

> On March 2, 2015, 9:38 p.m., Jie Yu wrote: > > src/linux/routing/filter/action.hpp, line 76 > > > > > > The name `Classifier` here is a little confusing because we already > > have `ip::Classifier`, `icmp::Classifier

Re: Review Request 31503: (2/4) Add the Classifier action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review74787 --- src/linux/routing/filter/action.hpp

Re: Review Request 31503: (2/4) Add the Classifier action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review74806 --- src/linux/routing/filter/action.hpp

Re: Review Request 31503: (2/4) Add the Classifier action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/ --- (Updated Feb. 27, 2015, 9:39 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 31503: (2/4) Add the Classifier action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review74414 --- Bad patch! Reviews applied: [31503] Failed command: ./support/appl

Re: Review Request 31503: (2/4) Add the Classifier action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/#review74394 --- please add a jira reference and a dependency on the first part. - D

Review Request 31503: (2/4) Add the Classifier action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31503/ --- Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Repository: mesos