Re: Review Request 31992: Added a TODO for readability reviews.

2015-03-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31992/#review76281 --- Patch looks great! Reviews applied: [31992] All tests passed. - M

Re: Review Request 31992: Added a TODO for readability reviews.

2015-03-12 Thread Benjamin Hindman
> On March 12, 2015, 6:53 p.m., Ben Mahler wrote: > > * Braces: placed on separate line for class / struct / function > > definitions. Same line otherwise. > > > > Do we want to tackle higher level style here that is currently missing from > > the style guide? > > > > * Use Try / Result to de

Re: Review Request 31992: Added a TODO for readability reviews.

2015-03-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31992/#review76271 --- * Braces: placed on separate line for class / struct / function defi

Review Request 31992: Added a TODO for readability reviews.

2015-03-12 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31992/ --- Review request for mesos, Bernd Mathiske and Ben Mahler. Repository: mesos De