Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 27, 2015, 2:49 p.m.) Review request for mesos. Changes ---

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review78044 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/flags/fl

Re: Review Request 32105: Added << operator to stout.flags.

> On March 26, 2015, 2:57 a.m., Michael Park wrote: > > Are we changing the format to be "--key0=val0 --key1=val1 --key2=val2"? > > Joerg Schad wrote: > Yes, following the discussion with BenM on the Jira. Ah ok, thanks! - Michael

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review77906 --- LGTM! - Michael Park On March 26, 2015, 8:29 a.m., Joerg Schad wr

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 26, 2015, 8:29 a.m.) Review request for mesos. Changes ---

Re: Review Request 32105: Added << operator to stout.flags.

> On March 26, 2015, 2:57 a.m., Michael Park wrote: > > Are we changing the format to be "--key0=val0 --key1=val1 --key2=val2"? Yes, following the discussion with BenM on the Jira. - Joerg --- This is an automatically generated e-mail.

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review77859 --- Are we changing the format to be "--key0=val0 --key1=val1 --key2=val

Re: Review Request 32105: Added << operator to stout.flags.

> On March 25, 2015, 3:30 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 592-600 > > > > > > How about breaking this up in order to avoid the ad-hoc `join` co

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 25, 2015, 11:20 p.m.) Review request for mesos. Changes --

Re: Review Request 32105: Added << operator to stout.flags.

> On March 25, 2015, 3:30 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 592-600 > > > > > > How about breaking this up in order to avoid the ad-hoc `join` co

Re: Review Request 32105: Added << operator to stout.flags.

> On March 25, 2015, 3:30 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 597 > > > > > > `s/<<"\""/<< "\""/` in both occurrences. Also, do we have a rule that we c

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review77735 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review77723 --- Ship it! Ship It! - Till Toenshoff On March 17, 2015, 12:25 a.m.

Re: Review Request 32105: Added << operator to stout.flags.

> On March 23, 2015, 5:44 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 588-603 > > > > > > As I see you create the body of a json object where all the el

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review77426 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review76706 --- Ship it! Ship It! - Alexander Rukletsov On March 17, 2015, 12:25

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 17, 2015, 12:25 a.m.) Review request for mesos. Changes --

Re: Review Request 32105: Added << operator to stout.flags.

> On March 16, 2015, 6:52 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 589 > > > > > > I think you need to `#include `. Sorry, you'll need the whole ``. T

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/#review76602 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/flags/fl

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 16, 2015, 6:11 p.m.) Review request for mesos. Changes ---

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 16, 2015, 4:13 p.m.) Review request for mesos. Changes ---

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 16, 2015, 3:22 p.m.) Review request for mesos. Changes ---

Re: Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- (Updated March 16, 2015, 3:10 p.m.) Review request for mesos. Bugs: Mesos-232

Review Request 32105: Added << operator to stout.flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32105/ --- Review request for mesos. Repository: mesos Description --- see summary