Re: Review Request 32797: Kill the executor when docker container is destroyed.

2015-04-03 Thread Timothy Chen
On April 3, 2015, 3:46 p.m., Benjamin Hindman wrote: src/slave/containerizer/docker.cpp, line 1230 https://reviews.apache.org/r/32797/diff/1/?file=914221#file914221line1230 Why kill the executor before doing Docker::stop? Can you comment here why you do it in this order versus

Re: Review Request 32797: Kill the executor when docker container is destroyed.

2015-04-03 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32797/#review78781 --- Ship it! Ship It! - Benjamin Hindman On April 2, 2015, 11:38

Re: Review Request 32797: Kill the executor when docker container is destroyed.

2015-04-03 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32797/#review78785 --- Ship it! I had another thought after my first review, see below

Review Request 32797: Kill the executor when docker container is destroyed.

2015-04-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32797/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.