Review Request 32820: Fixed the non-POD global variable in perf sampler.

2015-04-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32820/ --- Review request for mesos, Ben Mahler and Ian Downes. Repository: mesos

Re: Review Request 32820: Fixed the non-POD global variable in perf sampler.

2015-04-03 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32820/#review78832 --- Ship it! Ship It! - Ian Downes On April 3, 2015, 10:01 a.m.,

Re: Review Request 32820: Fixed the non-POD global variable in perf sampler.

2015-04-03 Thread Jie Yu
On April 3, 2015, 8:34 p.m., Ben Mahler wrote: src/linux/perf.cpp, lines 46-51 https://reviews.apache.org/r/32820/diff/1/?file=914812#file914812line46 char[] Also noticed many of our other constants are not static, we may want to do a sweep? Done. I'll do the sweep

Re: Review Request 32820: Fixed the non-POD global variable in perf sampler.

2015-04-03 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32820/#review78829 --- Ship it! Feel free to split out the proces namespace change.