[jira] [Commented] (METAMODEL-61) DataContext based on a directory of (CSV) files

2015-11-10 Thread Ashwin Rayaprolu (JIRA)
[ https://issues.apache.org/jira/browse/METAMODEL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998832#comment-14998832 ] Ashwin Rayaprolu commented on METAMODEL-61: --- ok > DataContext based on a dire

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Kasper Sørensen
> On nov. 10, 2015, 8:22 a.m., Kasper Sørensen wrote: > > Looks good to me! > > Sai Krishna Kishore Beathanabhotla wrote: > Hi Kasper, > I am unable to commit as I don't have privilages to commit to metamodel > project for my username, could you please help me resolve the issue. Hi Sai

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Sai Krishna Kishore Beathanabhotla
> On Nov. 10, 2015, 8:22 a.m., Kasper Sørensen wrote: > > Looks good to me! Hi Kasper, I am unable to commit as I don't have privilages to commit to metamodel project for my username, could you please help me resolve the issue. - Sai Krishna Kishore -

[jira] [Resolved] (METAMODEL-205) Excel: Validate table name before creating sheet

2015-11-10 Thread JIRA
[ https://issues.apache.org/jira/browse/METAMODEL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kasper Sørensen resolved METAMODEL-205. --- Resolution: Fixed Assignee: Sai Krishna Kishore Beathanabhotla Fix V

[jira] [Commented] (METAMODEL-61) DataContext based on a directory of (CSV) files

2015-11-10 Thread JIRA
[ https://issues.apache.org/jira/browse/METAMODEL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998388#comment-14998388 ] Kasper Sørensen commented on METAMODEL-61: -- I prefer you to not subclass but ra

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Sai Krishna Kishore Beathanabhotla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/#review105825 --- Ship it! Ship It! - Sai Krishna Kishore Beathanabhotla On Nov.

[jira] [Commented] (METAMODEL-61) DataContext based on a directory of (CSV) files

2015-11-10 Thread Ashwin Rayaprolu (JIRA)
[ https://issues.apache.org/jira/browse/METAMODEL-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998308#comment-14998308 ] Ashwin Rayaprolu commented on METAMODEL-61: --- I see that all CsvDataContext and

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

2015-11-10 Thread ashwinrayaprolu1984
Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155359607 Sure will proceed with above logic.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

2015-11-10 Thread kaspersorensen
Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155358929 Thanks for the feedback @albertostratio. I think we can then come to an agreement that both syntaxes (double quotes and square brackets) should be parseable by

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

2015-11-10 Thread albertostratio
Github user albertostratio commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155357162 If we're going to add this feature I'd also go for both syntaxes. IMO it won't be a good idea to force the user to use a specific one. @kaspersorensen y

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Kasper Sørensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/#review105809 --- Ship it! Looks good to me! - Kasper Sørensen On nov. 9, 2015, 1

[jira] [Commented] (METAMODEL-207) SingleLineCsvRow fails to serialize

2015-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METAMODEL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998233#comment-14998233 ] ASF GitHub Bot commented on METAMODEL-207: -- Github user asfgit closed the pull

[GitHub] metamodel pull request: METAMODEL-207: Fixed

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en