Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221327239
+0
Code is acceptable from me, but I think it would be better to separate
"parser" from "reader" here. A reader is a stateful thing IMO - it has a
poi
Already +101 then ;-)
Sorry Alberto, I think I then misunderstood your mail from March - I
though you had in mind to create a client-side DataContext that would
absorb a(ny) REST interface. Hence I was a bit like "that's nearly
impossible" in my response. But great that we had the same ideas then!
Github user ardlema commented on the pull request:
https://github.com/apache/metamodel/pull/106#issuecomment-221224230
Jira created:
[METAMODEL-1089](https://issues.apache.org/jira/browse/METAMODEL-1089)
Thank you @LosD
---
If your project is set up for it, you can reply to
Alberto created METAMODEL-1089:
--
Summary: MongoDB modules - Extract common code
Key: METAMODEL-1089
URL: https://issues.apache.org/jira/browse/METAMODEL-1089
Project: Apache MetaModel
Issue Type
[
https://issues.apache.org/jira/browse/METAMODEL-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298017#comment-15298017
]
ASF GitHub Bot commented on METAMODEL-1088:
---
Github user LosD commented on t
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/106#issuecomment-221222638
Yeah, that makes sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
[
https://issues.apache.org/jira/browse/METAMODEL-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298003#comment-15298003
]
ASF GitHub Bot commented on METAMODEL-1088:
---
Github user ardlema commented o
Github user ardlema commented on the pull request:
https://github.com/apache/metamodel/pull/106#issuecomment-221221171
Completely agree @LosD. When applying the changes I thought the same. I was
about to start refactoring the code but I thought that I shouldn't do this
within this PR.
[
https://issues.apache.org/jira/browse/METAMODEL-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297941#comment-15297941
]
ASF GitHub Bot commented on METAMODEL-1088:
---
Github user LosD commented on t
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/106#issuecomment-221211434
I know nothing about Mongodb, but code looks good :)
It does uncover one (unrelated) thing, though: It seems Mongo2 & 3 modules
are _very_ similar (a qucik glanc
Github user ClaudiaPHI commented on the pull request:
https://github.com/apache/metamodel/pull/105#issuecomment-221210380
I need to wait for this PR: https://github.com/apache/metamodel/pull/103 if
I am to avoid conflicts.
---
If your project is set up for it, you can reply to this e
[
https://issues.apache.org/jira/browse/METAMODEL-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297897#comment-15297897
]
ASF GitHub Bot commented on METAMODEL-1088:
---
GitHub user ardlema opened a pu
GitHub user ardlema opened a pull request:
https://github.com/apache/metamodel/pull/106
METAMODEL-1088 Find out aliases in columns
This PR includes the changes to fix METAMODEL-1088 by checking whether the
columns contain aliases and if so just delegating the query to the
QueryPost
Alberto created METAMODEL-1088:
--
Summary: Aliases do not work for MongoDB modules
Key: METAMODEL-1088
URL: https://issues.apache.org/jira/browse/METAMODEL-1088
Project: Apache MetaModel
Issue Ty
14 matches
Mail list logo
