Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Sai Krishna Kishore Beathanabhotla
rishna Kishore --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/#review105809 --- On Nov. 9, 2015, 11:15 p.m., Sai Krishna Kishore Beatha

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Sai Krishna Kishore Beathanabhotla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/#review105825 --- Ship it! Ship It! - Sai Krishna Kishore Beathanabhotla On Nov

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-09 Thread Sai Krishna Kishore Beathanabhotla
97101bd Diff: https://reviews.apache.org/r/40074/diff/ Testing --- 1) Added test cases for the same. 2) Verified with name greater than 31 characters. 3) Verified name with invalid characters like [ ] : \ / ? * Thanks, Sai Krishna Kishore Beathanabhotla

Re: METAMODEL-205 Code review

2015-11-09 Thread Sai Krishna Kishore Beathanabhotla
ther committer). > > So that said, I hope someone else will give a look because right now I am a > bit tied up, but might get time later. > > Kasper > > 2015-11-09 10:57 GMT+01:00 Sai Krishna Kishore Beathanabhotla < > beathanabhotla.kish...@gmail.com>: > > > Hi

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-09 Thread Sai Krishna Kishore Beathanabhotla
Diff: https://reviews.apache.org/r/40074/diff/ Testing --- 1) Added test cases for the same. 2) Verified with name greater than 31 characters. 3) Verified name with invalid characters like [ ] : \ / ? * Thanks, Sai Krishna Kishore Beathanabhotla

METAMODEL-205 Code review

2015-11-09 Thread Sai Krishna Kishore Beathanabhotla
Hi, I am very much interested in joining the metamodel development team, I have tried to fix METAMODEL-205 and raised a code review for Kasper thru review board review https://reviews.apache.org/r/40074/ Please do have a look and please revert back for any changes. Thanks & Regards, Sai Krishna