Github user arjansh commented on the issue:
https://github.com/apache/metamodel/pull/200
LGTM!
---
Github user arjansh commented on the issue:
https://github.com/apache/metamodel/pull/198
Changed the pull request, removed the yucky part and instead fixed it by
moving the `ElasticSearchMetaDataParserTest` from the
`MetaModel-elasticsearch-native` module to the `MetaModel
Github user arjansh commented on the issue:
https://github.com/apache/metamodel/pull/185
@kaspersorensen LGTM too then.
---
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/185#discussion_r211947345
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java ---
@@ -115,21 +115,23 @@ private String createSqlStatement(Table
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r196363308
--- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseClient.java
---
@@ -0,0 +1,207 @@
+/**
+ * Licensed to the Apache Software
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r196366302
--- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseClient.java
---
@@ -0,0 +1,207 @@
+/**
+ * Licensed to the Apache Software
Github user arjansh commented on the issue:
https://github.com/apache/metamodel/pull/182
I think the behavior of HBase is mostly similar to Cassandra and I do think
that we can improve on it in the future. We haven't addressed the reading from
HBase in this PR and that still has lots
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195718876
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseRowInsertionBuilder.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195718665
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseFamilyMap.java ---
@@ -106,9 +105,9 @@ public String toString
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195639023
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseFamilyMap.java ---
@@ -106,9 +105,9 @@ public String toString
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195638498
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseRowInsertionBuilder.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195638392
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseRowInsertionBuilder.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195067558
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseFamilyMap.java ---
@@ -106,9 +105,9 @@ public String toString
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195064147
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseRowInsertionBuilder.java ---
@@ -0,0 +1,200 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r195045275
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java ---
@@ -242,17 +240,18 @@ protected DataSet materializeMainSchemaTable
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193784059
--- Diff: hbase/src/main/java/org/apache/metamodel/hbase/HBaseColumn.java
---
@@ -0,0 +1,124 @@
+/**
+ * Licensed to the Apache Software
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193783947
--- Diff:
core/src/main/java/org/apache/metamodel/insert/AbstractRowInsertionBuilder.java
---
@@ -44,6 +44,12 @@ public AbstractRowInsertionBuilder(U
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/182#discussion_r193783877
--- Diff:
hbase/src/main/java/org/apache/metamodel/hbase/HBaseUpdateCallback.java ---
@@ -0,0 +1,112 @@
+/**
+ * Licensed to the Apache Software
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r191345706
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/Neo4jDataContext.java ---
@@ -52,23 +52,24 @@
* DataContext implementation for Neo4j
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190878656
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190899732
--- Diff: neo4j/src/main/java/org/apache/metamodel/neo4j/Neo4jDataSet.java
---
@@ -44,28 +44,32 @@ public Neo4jDataSet(List selectItems,
JSONObject
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190879379
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190877953
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190560674
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190560349
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,126 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190558268
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r190142943
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189916493
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ArrayColumnTypeHandler.java
---
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189893280
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/Neo4jDataContext.java ---
@@ -236,8 +256,8 @@ protected String getMainSchemaName() throws
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189885903
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/Neo4jDataContext.java ---
@@ -158,60 +159,79 @@ protected String getMainSchemaName() throws
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189903958
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeHandler.java ---
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189915253
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/AbstractColumnTypeHandler.java
---
@@ -0,0 +1,33 @@
+/**
+ * Licensed
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189905854
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189906596
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache
Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189892629
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/Neo4jDataContext.java ---
@@ -158,60 +159,79 @@ protected String getMainSchemaName() throws
GitHub user arjansh opened a pull request:
https://github.com/apache/metamodel/pull/177
Upgrade MetaModel dependency from 1.5.0 to 5.6.3
Biggest changes:
- Node client is no longer supported. If you want to connect as a node
client, you can "Start locally a Coordinating
GitHub user arjansh opened a pull request:
https://github.com/apache/metamodel/pull/126
Make it possible to use column naming strategy for EBCDIC files
Fixes METAMODEL-1114.
Introducing a new EbcdicConfiguration constructor which takes
ColumnNamingStrategy as an argument
GitHub user arjansh opened a pull request:
https://github.com/apache/metamodel/pull/125
Use ColumnNamingStrategy argument in CsvConfiguration constructor
Fixes METAMODEL-1113.
Added unit tests to the different types of datastores which can make use
38 matches
Mail list logo
