[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on a diff in the pull request: https://github.com/apache/metamodel/pull/72#discussion_r45000717 --- Diff: core/src/main/java/org/apache/metamodel/query/QueryConstants.java --- @@ -0,0 +1,41 @@ +/** + * Licensed to the Apache

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-156789594 Sure.. It got checked in by mistake.. Will remove those... > On Nov 15, 2015, at 12:07 AM, Kasper Sørensen wrote: > > I would s

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-156571141 Note sure why this checkin is failing.. Debugging that.. Need to go out will be back in 15 min and check my repository --- If your project is set up for

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-156570966 Please review code in https://github.com/ashwinrayaprolu1984/metamodel/commit/2a7aa9b7f4a9398ce0822d7eccb1f2d208affe8d core/src/main

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155359607 Sure will proceed with above logic.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155152411 I'll leave this decision up to you.. As you guys are owners of this.. But yeah i agree with @kaspersorensen that we should embrace everything...

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155143846 In this case i would prefer we defining metacharacter list in core API class which parse all token form its delimiters and returns value

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155097833 Will update in 2 hours and commit.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

Github user ashwinrayaprolu1984 commented on the pull request: https://github.com/apache/metamodel/pull/72#issuecomment-155094566 I was actually going that route but from my experience i found people always make mistakes in escaping double quotes and hence took this route.. I can

[GitHub] metamodel pull request: Updating FromItemParser to parse tableName...

GitHub user ashwinrayaprolu1984 opened a pull request: https://github.com/apache/metamodel/pull/72 Updating FromItemParser to parse tableNames with spaces I had a requirement where tablename contains spaces.. And FromItemParser is throwing exceptions. I made [] as token