Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-163160516
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r47067388
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -152,7 +166,24 @@ public SelectItem(Column column, FromItem fromItem) {
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r47067001
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -152,7 +166,24 @@ public SelectItem(Column column, FromItem fromItem) {
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-163144937
@kaspersorensen some minor comments take a look at them please
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r47059543
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -192,7 +223,7 @@ public SelectItem(FunctionType function, String
expre
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r47059535
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -178,7 +209,7 @@ public SelectItem(String expression, String alias) {
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r47059528
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -152,7 +166,24 @@ public SelectItem(Column column, FromItem fromItem) {
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r47059516
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -152,7 +166,24 @@ public SelectItem(Column column, FromItem fromItem) {
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-162528258
What do you think about merging this @albertostratio?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-160101871
OK, done with this PR for now. Please give another review if you can and
then we can merge hopefully?
---
If your project is set up for it, you can reply to th
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-160064824
OK I'll try and finish this one up then. I have let it linger for too long,
but finally I think actually it's a pretty good change.
---
If your project is set
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-158877708
@kaspersorensen I agree, the sooner we modify the interface the better.
Regarding my question about the json, if it requires another big change I
guess
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-158598865
To you example JSON: right now it would only return the first. If we wanted
it to be capable of changing the record count of the resulting dataset then I
guess
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r45542637
--- Diff: core/src/main/java/org/apache/metamodel/query/FromClause.java ---
@@ -75,7 +75,13 @@ public FromItem getItemByReference(String reference) {
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-158598709
I stopped a bit because it involved an interface change to ScalaFunction
which I think is kind of a pity - we just launched that interface. But otoh
it's maybe
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/70#issuecomment-158321263
@kaspersorensen are you still working on this PR? I think this function is
pretty useful.
And, I've got a question on this... Will it fetch all the "res
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r45444580
--- Diff: core/src/main/java/org/apache/metamodel/query/FromClause.java ---
@@ -75,7 +75,13 @@ public FromItem getItemByReference(String reference) {
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/70
METAMODEL-195 - a MAP_VALUE function
This PR attempts to fix METAMODEL-195, the addition of a MAP_VALUE function
which takes a string parameter to tell which value from within a map you wis
19 matches
Mail list logo
