Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r74330944
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/EbcdicReader.java ---
@@ -26,13 +26,17 @@
*/
class EbcdicReader extend
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r74198110
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/EbcdicReader.java ---
@@ -26,13 +26,17 @@
*/
class EbcdicReader extends Fix
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r74183535
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/EbcdicReader.java ---
@@ -26,13 +26,17 @@
*/
class EbcdicReader extend
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r73830409
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -43,6 +47,7 @@
private final boolean _constantW
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r73817859
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -43,6 +47,7 @@
private final boolean _cons
Github user jhorcicka commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/122#discussion_r73656991
--- Diff:
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthReader.java
---
@@ -85,6 +92,15 @@ public FixedWidthReader(InputStream stre
GitHub user jhorcicka opened a pull request:
https://github.com/apache/metamodel/pull/122
METAMODEL-1109: FixedWidthReader diacritics bug fix
Refactoring of FixedWidthReader in PR #103 introduced a bug related to
charset (which was not used). So, input containing diacritic characte
