[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-09 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/137#discussion_r91810278 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java --- @@ -460,4 +460,25 @@ public Object getResultSetValue

[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-09 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/137#discussion_r91810234 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java --- @@ -460,4 +460,25 @@ public Object getResultSetValue

[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-09 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/137#discussion_r91708292 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriter.java --- @@ -18,17 +18,19 @@ */ package org.apache.metamodel.j

[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-09 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/137#discussion_r91708492 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java --- @@ -460,4 +460,25 @@ public Object getResultSetValue(ResultSet

[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-09 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/137#discussion_r91708656 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java --- @@ -31,15 +33,10 @@ import org.apache.metamodel.schema.C

[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-09 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/137#discussion_r91708637 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriter.java --- @@ -18,17 +18,19 @@ */ package org.apache.metamodel.j

[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-09 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/137#discussion_r91708847 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java --- @@ -56,7 +53,7 @@ protected String rewriteSelectClause(Query

[GitHub] metamodel pull request #137: Metamodel 1132 sql native paging

2016-12-09 Thread rposkocil
GitHub user rposkocil opened a pull request: https://github.com/apache/metamodel/pull/137 Metamodel 1132 sql native paging fixes https://issues.apache.org/jira/browse/METAMODEL-1132 You can merge this pull request into a Git repository by running: $ git pull https://github.com/