Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/165
---
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148438583
--- Diff:
core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java ---
@@ -60,6 +60,49 @@
private final Table table1 =
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148367755
--- Diff:
core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java ---
@@ -60,6 +60,49 @@
private final Table table1 = schema.ge
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148367081
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -458,15 +459,18 @@ protected String getDefaultSchemaName() throws
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148356156
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
/*
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148174999
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148174162
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148174017
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148126992
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -235,38 +240,28 @@ private boolean isSimpleSelect(SelectClause clau
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148126961
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -216,8 +222,7 @@ public DataSet executeQuery(final Query query) {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148127164
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -385,8 +380,8 @@ protected DataSet materializeTable(final Table tab
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148127296
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
/*
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148127149
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -319,13 +314,13 @@ protected DataSet materializeFromItem(final From
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148126842
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -128,7 +134,7 @@ public DataSet executeQuery(final Query query) {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148127042
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -235,38 +240,28 @@ private boolean isSimpleSelect(SelectClause clau
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148127021
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -235,38 +240,28 @@ private boolean isSimpleSelect(SelectClause clau
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148126897
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -192,8 +198,8 @@ public DataSet executeQuery(final Query query) {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148126979
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -235,38 +240,28 @@ private boolean isSimpleSelect(SelectClause clau
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148127125
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -319,13 +314,13 @@ protected DataSet materializeFromItem(final From
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148126432
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
/*
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148123395
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -63,24 +64,29 @@
import org.slf4j.LoggerFactory;
/*
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/165#discussion_r148126868
--- Diff:
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java ---
@@ -151,8 +157,8 @@ public DataSet executeQuery(final Query query) {
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/165
METAMODEL-1165: Add alias default table
Another approach to METAMODEL-1165. This time with the use of alias tables.
Following the feedback from @LosD and @tomatophantastico from my previou
23 matches
Mail list logo
