Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Kasper Sørensen
> On nov. 10, 2015, 8:22 a.m., Kasper Sørensen wrote: > > Looks good to me! > > Sai Krishna Kishore Beathanabhotla wrote: > Hi Kasper, > I am unable to commit as I don't have privilages to commit to metamodel > project for my username, could you please help me resolve the issue. Hi Sai

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Sai Krishna Kishore Beathanabhotla
> On Nov. 10, 2015, 8:22 a.m., Kasper Sørensen wrote: > > Looks good to me! Hi Kasper, I am unable to commit as I don't have privilages to commit to metamodel project for my username, could you please help me resolve the issue. - Sai Krishna Kishore -

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Sai Krishna Kishore Beathanabhotla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/#review105825 --- Ship it! Ship It! - Sai Krishna Kishore Beathanabhotla On Nov.

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-10 Thread Kasper Sørensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/#review105809 --- Ship it! Looks good to me! - Kasper Sørensen On nov. 9, 2015, 1

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-09 Thread Sai Krishna Kishore Beathanabhotla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/ --- (Updated Nov. 9, 2015, 11:15 p.m.) Review request for MetaModel. Repository:

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-09 Thread Kasper Sørensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/#review105708 --- excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback

Re: Review Request 40074: Added validation to check for invalid characters and sheetname length for excel

2015-11-09 Thread Sai Krishna Kishore Beathanabhotla
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/ --- (Updated Nov. 9, 2015, 10:03 a.m.) Review request for MetaModel. Repository: