[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-01 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/606 METRON-980: Short circuit operations for Stellar ## Contributor Comments Stellar does not currently contain short circuit operations. In most languages, this is an important optimization, but f

[GitHub] metron issue #604: METRON-978: Management UI init script uses hard-coded MET...

2017-06-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/604 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] metron issue #577: METRON-746: Build Custom Checkstyle and IDE formatting se...

2017-06-01 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/577 @mmiklavc I didn't see any of that at all. All I saw was it either fixing things, or in certain cases (e.g. commas starting newlines) that it just left things alone. Autoformat won't fix everyth

[GitHub] metron issue #605: Metron-979 markdown errors in site-book

2017-06-01 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/605 Opened a PR against your branch. Generated the documentation and did a fair amount of manual review and couldn't find any broken code blocks, links, etc. --- If your project is set up for it, yo

[GitHub] metron pull request #605: Metron-979 markdown errors in site-book

2017-06-01 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/605#discussion_r119767454 --- Diff: metron-deployment/Kerberos-manual-setup.md --- @@ -382,18 +380,18 @@ Push Data 1. Push some sample data to one of the parser topics. E.g for

Re: [INCOMING] Metron 0.4.0 release (RC3)

2017-06-01 Thread Matt Foley
I would also appreciate a +1 on https://github.com/apache/metron/pull/605 On 6/1/17, 4:02 PM, "Matt Foley" wrote: The METRON-976 patch looks short and sweet. If someone familiar with that chunk of code can +1 it, it can go in too. On 6/1/17, 3:23 PM, "zeo...@gmail.com" wrot

[GitHub] metron pull request #605: Metron-979 markdown errors in site-book

2017-06-01 Thread mattf-horton
GitHub user mattf-horton opened a pull request: https://github.com/apache/metron/pull/605 Metron-979 markdown errors in site-book ## Contributor Comments Fixed multiple problems in markdown docs, mostly related to triple-backtick codeblocks nesting inside numbered lists. I now

[GitHub] metron issue #600: METRON-976 KafkaUtils doesn't handle SASL_PLAINTEXT

2017-06-01 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/600 Ran up in full dev, kerberized, stopped metron, changed configs in Kafka referencing PLAINTEXT/PLAINTEXT_SASL to SASL_PLAINTEXT (listeners and security.inter.broker.protocol), and restarted kafka

Re: [INCOMING] Metron 0.4.0 release (RC3)

2017-06-01 Thread Matt Foley
The METRON-976 patch looks short and sweet. If someone familiar with that chunk of code can +1 it, it can go in too. On 6/1/17, 3:23 PM, "zeo...@gmail.com" wrote: What about 976, which follows the Kerberized trend for this release? Jon On Thu, Jun 1, 2017, 6:03 PM Nick A

Re: [INCOMING] Metron 0.4.0 release (RC3)

2017-06-01 Thread zeo...@gmail.com
What about 976, which follows the Kerberized trend for this release? Jon On Thu, Jun 1, 2017, 6:03 PM Nick Allen wrote: > Sounds good, Matt. Looking forward to cutting this release. > > On Thu, Jun 1, 2017 at 5:17 PM, Matt Foley wrote: > > > Hi all, > > > > Now that METRON-844 is in, I plan t

Re: [INCOMING] Metron 0.4.0 release (RC3)

2017-06-01 Thread Nick Allen
Sounds good, Matt. Looking forward to cutting this release. On Thu, Jun 1, 2017 at 5:17 PM, Matt Foley wrote: > Hi all, > > Now that METRON-844 is in, I plan to proceed with the 0.4.0 release > candidate. I think 844 was the last item we considered a must-have for the > 0.4.0 release, and we w

[GitHub] metron pull request #604: added env file source to script

2017-06-01 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/604 added env file source to script ## Contributor Comments Fixes a minor bug in the management UI init script. That scripts now matches the REST init script. Tested in full dev. ## Pul

[INCOMING] Metron 0.4.0 release (RC3)

2017-06-01 Thread Matt Foley
Hi all, Now that METRON-844 is in, I plan to proceed with the 0.4.0 release candidate.  I think 844 was the last item we considered a must-have for the 0.4.0 release, and we want to post this release before incorporating several broad changes that should go in the NEXT release not this one (MET

[GitHub] metron pull request #572: METRON-633: Create better logging for HbaseEnrichm...

2017-06-01 Thread zezutom
Github user zezutom commented on a diff in the pull request: https://github.com/apache/metron/pull/572#discussion_r119730181 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/writer/SimpleHbaseEnrichmentWriter.java --- @@ -169,16 +188,19 @@ pub

[GitHub] metron pull request #547: METRON-858 bro-plugin-kafka is throwing segfaults

2017-06-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-06-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] metron issue #570: METRON-937 Pycapa Consume Messages from Begin, End, or St...

2017-06-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/570 +1, ran through steps. Thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] metron pull request #603: METRON-569: Enrichment topology duplicates message...

2017-06-01 Thread merrimanr
GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/603 METRON-569: Enrichment topology duplicates messages ## Contributor Comments This issue was discovered a while ago but a PR with a fix was never accepted. In summary, the JoinBolt is acking th

[GitHub] metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaults

2017-06-01 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/547 +1 Works like a charm. Tested basic functioning on a multi-node cluster against 1 gbps of canned traffic. Thanks for the contribution @JonZeolla ! --- If your project is set up for it, you can

[GitHub] metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaults

2017-06-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/547 +1 - although I can't do the stress testing part. Steps followed correctly work perfectly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] metron issue #570: METRON-937 Pycapa Consume Messages from Begin, End, or St...

2017-06-01 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/570 Please take a look-see. I'd like to get this fix in. Travis CI has passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] metron issue #570: METRON-937 Pycapa Consume Messages from Begin, End, or St...

2017-06-01 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/570 Travis is my friend --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-06-01 Thread nickwallen
Github user nickwallen closed the pull request at: https://github.com/apache/metron/pull/570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #570: METRON-937 Pycapa Consume Messages from Begin, End...

2017-06-01 Thread nickwallen
GitHub user nickwallen reopened a pull request: https://github.com/apache/metron/pull/570 METRON-937 Pycapa Consume Messages from Begin, End, or Stored Offsets ## Changes * I have altered Pycapa so that it can consume messages from either the beginning, end or the previousl

[GitHub] metron issue #600: METRON-976 KafkaUtils doesn't handle SASL_PLAINTEXT

2017-06-01 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/600 I will happily assign over credit to you. Thanks for catching the bug @justinleet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] metron issue #547: METRON-858 bro-plugin-kafka is throwing segfaults

2017-06-01 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/547 Just ran through the instructions from scratch and it works for me, can you give it another shot from the beginning? --- If your project is set up for it, you can reply to this email and have your

[GitHub] metron pull request #602: METRON-906: Rest service storm configuration does ...

2017-06-01 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/metron/pull/602 METRON-906: Rest service storm configuration does not allow for proper URLs ## Contributor Comments Allows for protocol to be used in the Storm REST URL (e.g. http:// and https://). Prior to