[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-27 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/624#discussion_r124317746 --- Diff: .travis.yml --- @@ -17,7 +17,7 @@ before_install: - export PATH=$M2_HOME/bin:$PATH script: - | --- End diff

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-27 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/624 As a note, what I have is currently the first steps towards reusing infra. It's not perfect, and it's not reused across classes. There was an attempt to use the build matrix to split

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-26 Thread justinleet
GitHub user justinleet reopened a pull request: https://github.com/apache/metron/pull/624 [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maximum Time Limit ## Contributor Comments Given that Apache travis fails more often, I'm using this PR to hopefully hit the skidoo

[GitHub] metron pull request #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceed...

2017-06-26 Thread justinleet
Github user justinleet closed the pull request at: https://github.com/apache/metron/pull/624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metron issue #624: [DO NOT MERGE] METRON-1004: Travis CI - Job Exceeded Maxi...

2017-06-26 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/624 I moved work from a mostly unrelated branch over here. Specifically, it attempts to get the InMemoryComponents to be reused across a given test class. This is particularly helpful

[GitHub] metron issue #615: METRON-995: Temporary variables in stellar enrichments wh...

2017-06-19 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/615 +1 by inspection, thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron issue #586: METRON-508 Expand Elasticsearch templates to support the ...

2017-06-19 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/586 @JonZeolla Can you deconflict this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron pull request #586: METRON-508 Expand Elasticsearch templates to suppo...

2017-06-19 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/586#discussion_r122717740 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/bro/BasicBroParserTest.java --- @@ -241,8 +380,754 @@ public void

[GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...

2017-06-19 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/607#discussion_r122700117 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java --- @@ -49,6 +44,11 @@ public

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-09 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r121161467 --- Diff: metron-extensions/metron-parser-extensions/metron-parser-bro-extension/metron-parser-bro/src/main/config/zookeeper/enrichments/bro.json

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-09 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r121157776 --- Diff: bundles-maven-plugin/README.md --- @@ -0,0 +1,89 @@ + +# Apache Metron Bundle Maven Plugin --- End diff -- With my limited

[GitHub] metron issue #606: METRON-980: Short circuit operations for Stellar

2017-06-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/606 Thanks for submitting this, and thanks for the responses to the notes. I'm +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron issue #609: METRON-987: Allow stellar enrichments to be specified by ...

2017-06-08 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/609 @cestella Perfect. Definitely didn't want to imply that belongs in this ticket at all. I'm in full support of it being backwards compatible for now, and keeping the discussion of how we prune

[GitHub] metron pull request #614: METRON-992: Create performance tuning guide

2017-06-08 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/614#discussion_r120964479 --- Diff: metron-platform/Performance-tuning-guide.md --- @@ -0,0 +1,326 @@ +# Metron Performance Tunining Guide + +## Overview

[GitHub] metron pull request #614: METRON-992: Create performance tuning guide

2017-06-08 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/614#discussion_r120964036 --- Diff: metron-platform/Performance-tuning-guide.md --- @@ -0,0 +1,326 @@ +# Metron Performance Tunining Guide --- End diff

[GitHub] metron pull request #609: METRON-987: Allow stellar enrichments to be specif...

2017-06-08 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/609#discussion_r120932742 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/message/JSONFromPosition.java --- @@ -40,10 +40,12 @@ public

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-08 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r120926071 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/StellarCompiler.java --- @@ -76,14 +93,80 @@ public Expression

[GitHub] metron pull request #609: METRON-987: Allow stellar enrichments to be specif...

2017-06-08 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/609#discussion_r120919459 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/message/JSONFromPosition.java --- @@ -40,10 +40,12 @@ public

[GitHub] metron pull request #609: METRON-987: Allow stellar enrichments to be specif...

2017-06-08 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/609#discussion_r120921756 --- Diff: metron-platform/metron-enrichment/src/test/java/org/apache/metron/enrichment/adapters/stellar/StellarAdapterTest.java --- @@ -0,0 +1,134

[GitHub] metron issue #609: METRON-987: Allow stellar enrichments to be specified by ...

2017-06-08 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/609 A lot of this brings up the discussions around deprecating / dropping functionality (both for Stellar and in general). It seems like ideally, we'd be deprecating the map functionality in favor

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2017-06-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/579 Just the start. I got the previously existing test cases in a better shape, and @ctramnitz should be able to add on pretty easily. I do want to echo what @mattf-horton said about

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2017-06-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/579 https://github.com/ctramnitz/metron/pull/1 opened, if anyone cares. As noted, https://github.com/ctramnitz/metron/commit/bf8ce62cb5ed3846f288e4a7a606410ebbaf9d30 is the relevant commit

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2017-06-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/579 I lied, it's a bit circular. It depends on your PR's fixes, so let's go back to the original strategy of making a PR against your branch. I'm more than happy to give up credit, since

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2017-06-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/579 Actually, I'll just open a separate ticket/PR. You'll still want to merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/530 @ottobackwards I agree the feature branch approach is probably the best way to handle things like this. It naturally splits things into a smaller chunks, and it eliminates the need for all

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/530 @ottobackwards I definitely agree that we need more documentation around absolutely everything you listed. The main reason I want the outline for adding a new parser is just so I have a way

[GitHub] metron issue #530: METRON-777 Metron Extension System and Parser Extensions

2017-06-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/530 @nickwallen I agree in philosophy, but this has been a running PR for awhile that had plenty of dev list discussion around it before it was made. There's already follow-on work being done

[GitHub] metron issue #612: METRON-962: Configuration Based Unit Tests and Add integr...

2017-06-07 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/612 @kylerichardson What is the difference between the `BasicAsaParser` and the `GrokAsaParser`? Are you able to shed some light on why both exist? The motivation for the question is that minor

[GitHub] metron pull request #602: METRON-906: Rest service storm configuration does ...

2017-06-07 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/602#discussion_r120614845 --- Diff: metron-deployment/roles/ambari_config/vars/single_node_vm.yml --- @@ -102,7 +102,7 @@ configurations: required_configurations

[GitHub] metron pull request #530: METRON-777 Metron Extension System and Parser Exte...

2017-06-07 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/530#discussion_r120369783 --- Diff: bundles-lib/pom.xml --- @@ -0,0 +1,206 @@ + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLS

[GitHub] metron issue #579: METRON-941 fix PaloAltoParser

2017-06-06 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/579 I just kicked up https://github.com/apache/metron/pull/612, which theoretically fixes the unit tests (and simplifies them a lot). Straight replacing the logs would work, but we might want

[GitHub] metron pull request #612: METRON-962: Configuration Based Unit Tests and Add...

2017-06-06 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/metron/pull/612 METRON-962: Configuration Based Unit Tests and Add integration tests ## Contributor Comments Admittedly, this mixes a couple things together. I originally intended to get rid of JUnit3

[GitHub] metron issue #600: METRON-976 KafkaUtils doesn't handle SASL_PLAINTEXT

2017-06-06 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/600 @mattf-horton Updated with a more explicit set of unit tests around it and a comment explaining the assumption made by the function. Let me know if there's anything else you want or need to make

[GitHub] metron pull request #600: METRON-976 KafkaUtils doesn't handle SASL_PLAINTEX...

2017-06-06 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/600#discussion_r120434003 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/KafkaUtils.java --- @@ -68,12 +68,14 @@ return ret

[GitHub] metron pull request #600: METRON-976 KafkaUtils doesn't handle SASL_PLAINTEX...

2017-06-06 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/600#discussion_r120369355 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/KafkaUtils.java --- @@ -68,12 +68,14 @@ return ret

[GitHub] metron pull request #607: METRON-982 add new rest api for storm supervisor s...

2017-06-06 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/607#discussion_r120367143 --- Diff: metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java --- @@ -49,6 +44,11 @@ public

[GitHub] metron issue #605: Metron-979 markdown errors in site-book

2017-06-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/605 @mattf-horton is correct, I am +1 on this. Thanks a lot for working on this, it's great to have. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119832707 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -634,6 +679,40 @@ public void

[GitHub] metron pull request #606: METRON-980: Short circuit operations for Stellar

2017-06-02 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/606#discussion_r119831834 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -33,19 +31,66 @@ import

[GitHub] metron pull request #605: Metron-979 markdown errors in site-book

2017-06-01 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/605#discussion_r119767454 --- Diff: metron-deployment/Kerberos-manual-setup.md --- @@ -382,18 +380,18 @@ Push Data 1. Push some sample data to one of the parser topics. E.g

[GitHub] metron issue #507: METRON-819: Document kafka console producer parameter for...

2017-05-31 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/507 I'm +1, by inspection. I think this covers it. I'll let @nickwallen double check if there's anything else. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metron pull request #600: METRON-976 KafkaUtils doesn't handle SASL_PLAINTEX...

2017-05-31 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/metron/pull/600 METRON-976 KafkaUtils doesn't handle SASL_PLAINTEXT ## Contributor Comments Used @cestella's original implementation before I apparently foolishly assumed we'd get Java compliant URIs. See

[GitHub] metron issue #595: METRON-964: Add logging in JoinBolt for unexpected cache ...

2017-05-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/595 +1, looks good and shows up in UI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #598: METRON-974 Document How to Run Stellar REPL From Source C...

2017-05-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/598 +1 by inspection, pending Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #507: METRON-819: Document kafka console producer parameter for...

2017-05-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/507 @mmiklavc Can you take care of the conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #520: METRON-833: Update MaaS documentation to explain how it i...

2017-05-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/520 @cestella Can you deconflict this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron issue #550: METRON-890: Intermittent unit test errors in shutting dow...

2017-05-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/550 @cestella Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] metron issue #577: METRON-746: Build Custom Checkstyle and IDE formatting se...

2017-05-27 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/577 Resolved conflicts. @mmiklavc I think you said on another PR that you'd seen some issues with the Google formatting? Any update on that? --- If your project is set up for it, you can

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-26 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118785519 --- Diff: metron-interface/metron-config/scripts/package.json --- @@ -9,7 +9,8 @@ "http-proxy-middleware": "0.17.4",

[GitHub] metron pull request #581: METRON-844: Install Metron Management UI with Amba...

2017-05-25 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/581#discussion_r118625900 --- Diff: metron-interface/metron-config/scripts/package.json --- @@ -9,7 +9,8 @@ "http-proxy-middleware": "0.17.4",

[GitHub] metron issue #591: METRON-959 Trivial documentation formatting bugs

2017-05-25 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/591 @JonZeolla Sounds like Otto got his commit working. You should be good to try this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] metron issue #594: METRON-963 Update document for Kerberos manual setup

2017-05-19 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/594 +1 by inspection. Thanks a lot for cleaning this up! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #596: METRON-965: In the case where we specify the syncpolicy i...

2017-05-19 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/596 Are there any unit tests we can/should add to add this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #591: METRON-959 Trivial documentation formatting bugs

2017-05-17 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/591 +1 by inspection. Good catch, and thanks for fixing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] metron issue #588: METRON-954: Create ability to change output topic of pars...

2017-05-16 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/588 I'm +1. Thanks for adding this. @ottobackwards You need to see anything on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] metron pull request #585: METRON-936: Fixes to pcap for performance and test...

2017-05-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/585#discussion_r116823693 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/HDFSWriterCallback.java --- @@ -116,7 +117,11 @@ public

[GitHub] metron issue #567: METRON-891: Changed Kafka API to Create a KafkaConsumer P...

2017-05-16 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/567 I'm set, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] metron pull request #585: METRON-936: Fixes to pcap for performance and test...

2017-05-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/585#discussion_r116795288 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/deserializer/KeyValueDeserializer.java --- @@ -28,6 +26,17

[GitHub] metron issue #589: METRON-955: Make the default sync policy for HDFS Writer ...

2017-05-16 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/589 I'm +1 by inspection, thanks for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #584: METRON-950: Migrate storm-kafka-client to 1.1

2017-05-16 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/584 Same here, +1. Thanks a lot for the contribution, this makes a big difference. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metron pull request #585: METRON-936: Fixes to pcap for performance and test...

2017-05-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/585#discussion_r116742092 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/deserializer/KeyValueDeserializer.java --- @@ -28,6 +26,17

[GitHub] metron pull request #585: METRON-936: Fixes to pcap for performance and test...

2017-05-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/585#discussion_r116741150 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/PartitionHDFSWriter.java --- @@ -102,14 +106,43 @@ public void

[GitHub] metron pull request #585: METRON-936: Fixes to pcap for performance and test...

2017-05-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/585#discussion_r116741758 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/PartitionHDFSWriter.java --- @@ -183,14 +219,14 @@ private void

[GitHub] metron pull request #585: METRON-936: Fixes to pcap for performance and test...

2017-05-16 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/585#discussion_r116739444 --- Diff: metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/PartitionHDFSWriter.java --- @@ -102,14 +106,43 @@ public void

[GitHub] metron issue #584: METRON-950: Migrate storm-kafka-client to 1.1

2017-05-16 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/584 I ran up the main topologies last night and everything seemed to correlate correctly and ran without issue. Hadn't run up pcap yet, but it look like @mmiklavc is working on validating it. Given

[GitHub] metron pull request #590: METRON-953: Complete migration away from incubator...

2017-05-15 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/metron/pull/590 METRON-953: Complete migration away from incubator-metron to metron for links and docs ## Contributor Comments Moving "incubator-metron" to "metron" everywhere other th

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

2017-05-15 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116564604 --- Diff: metron-platform/metron-storm-kafka-override/src/main/java/org/apache/storm/kafka/spout/internal/Timer.java --- @@ -0,0 +1,58

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

2017-05-15 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116566613 --- Diff: metron-platform/metron-storm-kafka/src/main/java/org/apache/metron/storm/kafka/flux/SimpleStormKafkaBuilder.java --- @@ -202,31 +240,4

[GitHub] metron pull request #584: METRON-950: Migrate storm-kafka-client to 1.1

2017-05-15 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/metron/pull/584#discussion_r116568707 --- Diff: pom.xml --- @@ -106,7 +122,7 @@ but I justify it by noting that this should be able to be removed when we migrate

[GitHub] metron issue #587: METRON-952 Travis CI Link in README Pointing to Old Repo

2017-05-15 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/587 I'll create a ticket and take care of it. I have a lot of this already done, while I was looking through last night. I was hoping to get a comprehensive ticket out with this change, but I'm

[GitHub] metron issue #587: METRON-952 Travis CI Link in README Pointing to Old Repo

2017-05-15 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/587 I actually also noticed this last night, and was about to put in a patch until I realized there's a good amount of documentation in general that needs to point to the newer repos, and our docs

[GitHub] metron pull request #577: METRON-746: Build Custom Checkstyle and IDE format...

2017-05-12 Thread justinleet
Github user justinleet closed the pull request at: https://github.com/apache/metron/pull/577 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-metron pull request #577: METRON-746: Build Custom Checkstyle and ...

2017-05-09 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/incubator-metron/pull/577 METRON-746: Build Custom Checkstyle and IDE formatting settings ## Contributor Comments Pretty much just editing the POM to actually set up Checkstyle with the Google Code

[GitHub] incubator-metron issue #575: METRON-944: markdown table causes infinite hang...

2017-05-09 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/575 @mattf-horton Thanks for catching that. Merged it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron pull request #573: METRON-943: Create traffic connections r...

2017-05-09 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/incubator-metron/pull/573 METRON-943: Create traffic connections report in zeppelin ## Contributor Comments Adds a Zeppelin dashboard that lets the user get connection counts filtered by a CIDR block

[GitHub] incubator-metron issue #563: METRON-840: All "ambari_*" hosts need to have a...

2017-05-05 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/563 @nickwallen @merrimanr Looks like the REST Ambari stuff. I probably should have caught it in review, but it looks like our blueprint needs updating to reflect it. --- If your project

[GitHub] incubator-metron issue #500: METRON-795: Install Metron REST with Ambari MPa...

2017-05-04 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/500 +1 pending Travis, thanks for taking care of the various comments and fixes here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

2017-05-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/459 @mmiklavc That order is correct, yes. Updated the main PR with a strikethrough and replace of the original. --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

2017-05-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/459 After looking at this some more, I split out the `mvn clean install` from `mvn site site:stage-deploy site:deploy`. Things got interleaved oddly and gave a similar package vs. install

[GitHub] incubator-metron pull request #556: METRON-903: Create a connections report ...

2017-05-02 Thread justinleet
Github user justinleet closed the pull request at: https://github.com/apache/incubator-metron/pull/556 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron issue #556: METRON-903: Create a connections report in Zepp...

2017-05-02 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/556 https://cloud.githubusercontent.com/assets/5077341/25616072/a91ab55c-2f08-11e7-82a0-1edc95364906.png;> With the bracketed time windows following the other panes. --- If y

[GitHub] incubator-metron issue #556: METRON-903: Create a connections report in Zepp...

2017-05-01 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/556 Updated with the Bro split, removing aggregate paragraphs, and Snort verbiage. Working on histogram. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-metron issue #500: METRON-795: Install Metron REST with Ambari MPa...

2017-05-01 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/500 I was able to run this up in a nonkerberized cluster, and then set up Kerberos. Mostly things worked, but I spun out two tickets from this, [METRON-909](https://issues.apache.org/jira

[GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

2017-04-30 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/459 Ran this up for a little while in down time over the last couple days. These counts include the previous updates (so 2 additional failures and 15 successes, and 1 additional failure

[GitHub] incubator-metron pull request #459: METRON-726: Clean up mvn site generation

2017-04-30 Thread justinleet
Github user justinleet closed the pull request at: https://github.com/apache/incubator-metron/pull/459 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron issue #553: METRON-896: Document Having Kerberos Issue Rene...

2017-04-28 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/553 Updated after merging in master, which included the README fixes as well as moving the Ambari instructions alongside the Manual instructions. --- If your project is set up for it, you

[GitHub] incubator-metron issue #553: METRON-896: Document Having Kerberos Issue Rene...

2017-04-27 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/553 To elaborate on the regression comment: The vagrant Kerberos steps have all the manual steps added back in. They should largely be removed, barring any profiler ACL setup

[GitHub] incubator-metron issue #553: METRON-896: Document Having Kerberos Issue Rene...

2017-04-27 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/553 Imo, the vagrant one should be moved up to the level of the manual one, and just made to be the Ambari Kerberos doc with any notes for full dev. Combining them is kind of a pain

[GitHub] incubator-metron issue #541: METRON-870: Add filtering by packet payload to ...

2017-04-27 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/541 +1, pending Travis. Was able to spin this up and full dev and everything worked as expected. Thanks a lot for the contribution. --- If your project is set up for it, you can reply

[GitHub] incubator-metron pull request #553: METRON-896: Document Having Kerberos Iss...

2017-04-27 Thread justinleet
GitHub user justinleet reopened a pull request: https://github.com/apache/incubator-metron/pull/553 METRON-896: Document Having Kerberos Issue Renewable Tickets ## Contributor Comments Added a couple lines to the doc about setting up tickets as renewable, if they aren't already

[GitHub] incubator-metron pull request #553: METRON-896: Document Having Kerberos Iss...

2017-04-27 Thread justinleet
Github user justinleet closed the pull request at: https://github.com/apache/incubator-metron/pull/553 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron pull request #553: METRON-896: Document Having Kerberos Iss...

2017-04-27 Thread justinleet
GitHub user justinleet opened a pull request: https://github.com/apache/incubator-metron/pull/553 METRON-896: Document Having Kerberos Issue Renewable Tickets ## Contributor Comments Added a couple lines to the doc about setting up tickets as renewable, if they aren't already

[GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

2017-04-27 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/459 To my surprise, I just ran 17 times overnight on the branch with no issues. I'm going to repeat this over the next couple nights for both master and the branch, because having

[GitHub] incubator-metron pull request #541: METRON-870: Add filtering by packet payl...

2017-04-26 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/541#discussion_r113468302 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/filter/fixed/FixedPcapFilter.java --- @@ -21,76 +21,131

[GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

2017-04-26 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/459 For the errors on master: [master_error.txt](https://github.com/apache/incubator-metron/files/958364/master_error.txt) 4 BUILD FAILURE 8 BUILD SUCCESS

[GitHub] incubator-metron issue #459: METRON-726: Clean up mvn site generation

2017-04-26 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/459 @cestella I wish, I'd have been more than willing to ignore issues if it was. I'm scraping together a more concise version of the some of the logs and will post them. --- If your

[GitHub] incubator-metron issue #549: METRON-889: Regression introduced in Full Dev

2017-04-26 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/549 A PR was opened up at https://github.com/apache/incubator-metron/pull/552. Given that both involve spinning up quick/full dev, I'm personally inclined to hold off on the revert

[GitHub] incubator-metron pull request #538: METRON-868 Fix documentation on building...

2017-04-24 Thread justinleet
Github user justinleet closed the pull request at: https://github.com/apache/incubator-metron/pull/538 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-metron pull request #544: METRON-866 Quickdev and Fulldev readme m...

2017-04-24 Thread justinleet
Github user justinleet commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/544#discussion_r112961515 --- Diff: metron-deployment/vagrant/full-dev-platform/README.md --- @@ -24,35 +26,38 @@ Any platform that supports these tools is suitable

[GitHub] incubator-metron issue #538: METRON-868 Fix documentation on building RPMs

2017-04-24 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/incubator-metron/pull/538 @mmiklavc Added a quick note, and listed those dependencies off. Let me know if there's anything else you want in there. --- If your project is set up for it, you can reply

<    1   2   3   4   5   6   >