Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135655011
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/metainfo.xml
---
@@ -119,6 +119,45
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135261317
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135258100
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-profiler-env.xml
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135256865
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135256262
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/params_linux.py
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/709#discussion_r135255635
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/694
The latest commit addresses the formatting comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/702
The latest commit moves this group by function to it's own REST endpoint.
Combining groups and search results became too awkward once I started looking
into adding sorting and size constraints
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/694#discussion_r135085139
--- Diff:
metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/AlertsProfile.java
---
@@ -0,0 +1,89
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/694#discussion_r135084490
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java
---
@@ -106,4 +107,33 @@ public void
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/694#discussion_r135084360
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java
---
@@ -0,0 +1,226
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/694#discussion_r135084396
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java
---
@@ -0,0 +1,226
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/677#discussion_r134860066
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -100,7 +107,16 @@ public
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/699
I have tested this in full dev and it works as advertised. I haven't
noticed any obvious bugs and it was fairly easy to install and start. I would
suggest we add a note in the "Development
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/711
METRON-1127: Add ability to escalate alerts for external consumption
## Contributor Comments
This PR exposes a way to put alerts (or any message) into a configurable
escalation Kafka topic
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/530
There are some consequences of not having the bundle classes available in
rest. The list of available classes will only contain metron-parsers homed
parser types so those are the only type
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/702
No, the "from" parameter is not supported.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/703
Try to save and/or retrieve a SensorParserConfig with Swagger in full dev.
Those 2 properties should now be present. See
SensorParserConfigControllerIntegrationTest for an example.
---
If your
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r134229213
--- Diff: metron-interface/metron-alerts/src/app/service/rest-api-impl.ts
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/703
Also updated the REST SensorParserConfig test to catch this type of error
in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/700#discussion_r133840897
--- Diff: metron-interface/metron-alerts/src/app/service/rest-api-impl.ts
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache Software Foundation
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/703
METRON-1115: Jackson is not properly serializing readMetadata and
mergeMetadata SensorParserConfig properties
## Contributor Comments
The getter methods for readMetadata and mergeMetadata
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/702
METRON-1114: Add group by capabilities to search REST endpoint
## Contributor Comments
This PR adds a group by feature to the search REST endpoint. This PR is
fairly complex so I don't think
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/694#discussion_r133735783
--- Diff: dependencies_with_url.csv ---
@@ -112,6 +112,7 @@
com.fasterxml.jackson.core:jackson-core:jar:2.6.6:compile,ASLv2,https://github.c
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/701
METRON-1113: UpdateControllerIntegrationTest fails with 500 error
## Contributor Comments
This PR moves the MockHBaseTableProvider.addToCache call from @BeforeClass
methods to a static block
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/696
METRON-1109: Indexing topology fails to start after Kerberos is enabled
## Contributor Comments
There were a couple of syntax errors in indexing_commands.py that keeps the
indexing topology
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/694
METRON-1085: Add REST endpoint to save a user profile for the Alerts UI
## Contributor Comments
This PR adds an ORM framework to the REST application. An ORM (object
relational mapping
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/620
+1 nice work @iraghumitra
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/683
@justinleet there are actually 2 package.json files in the management UI
module. I just fixed the other one too. Can you check it out again?
---
If your project is set up for it, you can reply
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/683#discussion_r131652946
--- Diff: metron-interface/metron-config/scripts/package.json ---
@@ -18,5 +18,5 @@
},
"private": true,
"author":
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/684
DO NOT MERGE: METRON-1086: Create a Blockly-based user interface for Stellar
## Contributor Comments
This PR is a first look at the Blockly/Stellar integration with a working
example
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/683
METRON-1084: Management UI web server license should be Apache
## Contributor Comments
Minor license correction.
## Pull Request Checklist
Thank you for submitting
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/679#discussion_r131151368
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -179,4 +206,43 @@ public
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/679
METRON-1075: Add faceted search capabilities
## Contributor Comments
This PR adds faceted search to indexing DAO. This can be tested in full
dev with Swagger. When searching with the "
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/677
METRON-1073: Add option to limit fields returned from search query
## Contributor Comments
This PR adds the option to explicitly declare which fields should be
returned in search results
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/673#discussion_r130129238
--- Diff: metron-deployment/packaging/ambari/README.md ---
@@ -0,0 +1,315 @@
+# Ambari Management Pack Development
+Typically, Ambari Management
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/673#discussion_r130128846
--- Diff: metron-deployment/packaging/ambari/README.md ---
@@ -0,0 +1,315 @@
+# Ambari Management Pack Development
+Typically, Ambari Management
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/669
I was able to get this to work in an Ubuntu cluster. I had to adjust the
metron-rest init script to get JAVA_HOME from Ambari. This is ready for review.
---
If your project is set up
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129930004
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java
---
@@ -182,6 +185,16
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129926344
--- Diff:
metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/SupervisorStatus.java
---
@@ -0,0 +1,127
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129897123
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java
---
@@ -17,10 +17,7
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/673
Sure I'll write something up on the mpack redeploy.
We could explain metron_theme.json as a seperate PR but these instructions
may be incomplete without it. For example, I'm not sure
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/673
We also might want to include suggestions for editing metron_theme.json.
That has become more important now that we are organizing properties in
different sections with different widgets Happy
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129692618
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/StormControllerIntegrationTest.java
---
@@ -182,6 +185,16
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129691439
--- Diff:
metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/SupervisorStatus.java
---
@@ -0,0 +1,127
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/607#discussion_r129690884
--- Diff:
metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/SupervisorStatus.java
---
@@ -0,0 +1,127
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/669
METRON-1064: Make init script OS-agnostic
## Contributor Comments
This PR makes the init scripts for metron-rest and metron-config
OS-agnostic by:
- moving the metron env file to "
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/607
Hey @ottobackwards, list has been on my todo list for a while. I'll spin
it up today or tomorrow. Sorry for the delay.
---
If your project is set up for it, you can reply to this email and have
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/662#discussion_r129147257
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/FieldType.java
---
@@ -0,0 +1,52
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/662#discussion_r129145507
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/SearchController.java
---
@@ -45,4 +49,18 @@
ResponseEntity
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/662#discussion_r129143530
--- Diff: metron-interface/metron-rest/README.md ---
@@ -353,6 +355,20 @@ Request and Response objects are JSON formatted. The
JSON schemas are available
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/662
Sure @ottobackwards. There is a similar api for Solr that will return
field types for a list of collections. When we add Solr as an indexing option
we will create a "SolrDao&q
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/636
I added this endpoint to the README with the latest commit and also tested
on full dev with Kerberos enabled.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/636
What do you think @ottobackwards? Are you good with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/658
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/657
Nevermind, LoggerFactory is static. For what it's worth, adding
`org.mockito.Mockito.reset(logger);` to setUp() worked for me.
---
If your project is set up for it, you can reply to this email
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/657
Why not just move line 60 (`logger = mock(Logger.class);`) to the setup
method? Since you're testing interactions with this mock it would be better to
have a new one for every test
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r127832531
--- Diff: metron-interface/metron-alerts/src/app/service/data-source.ts ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/647
+1 validated with instructions in the PR description. Nice work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/645
Their status will "Active" but you'll see Kerberos errors in the Storm UI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/645
Without it, the enrichment and indexing topologies don't work on a
Kerberized environment because the Storm worker childopts property needs the
"-Djava.security.auth.login.config=
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/359
@DomenicPuzio, this has been resolved by
https://github.com/apache/metron/pull/603. Can we close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/647#discussion_r127555429
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/metron.j2
---
@@ -37,3
Github user merrimanr closed the pull request at:
https://github.com/apache/metron/pull/654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/654#discussion_r127531933
--- Diff:
metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java
---
@@ -118,6 +118,20 @@ public void
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/654#discussion_r127527166
--- Diff:
metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java
---
@@ -118,6 +118,20 @@ public void
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/647#discussion_r127473184
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormCLIWrapper.java
---
@@ -75,37 +81,50 @@ public int
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/647#discussion_r127466486
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormCLIWrapper.java
---
@@ -75,37 +81,50 @@ public int
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/646
Hive provides a list of supported databases:
https://cwiki.apache.org/confluence/display/Hive/AdminManual+MetastoreAdmin#AdminManualMetastoreAdmin-Local/EmbeddedMetastoreDatabase(Derby
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/646
@ottobackwards it's in metron-rest README but I can expand it a little bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/646
The comment "This is needed when configuring MySQL for Metron REST because
this property must be" is actually incorrect now that I go back and look at it.
The schema-mysql.sql was
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/646
Spring provides a mechanism for running sql scripts for different databases
on startup. This is useful for initializing tables and such. We provide 2
right now: schema-h2.sql and schema
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/636
The latest commit enforces a maximum page size. A value of 1000 is set by
default. As it currently stands, you would need to add this property to the
rest_application.yml file manually
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/634#discussion_r126789624
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/634#discussion_r126788288
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/646
METRON-1030: Metron JDBC platform REST option should accept a blank value
## Contributor Comments
Ambari should allow the metron_jdbc_platform option to be set to '' which
it currently does
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/645
METRON-1029: Topology worker opts are not being set when Kerberos is enabled
## Contributor Comments
This PR properly sets the topology worker opts property for enrichment and
indexing
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/620
I just added some comments related to abstracting the search service. Much
improved with the latest commits. I think we're almost there.
---
If your project is set up for it, you can reply
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r126532937
--- Diff: metron-interface/metron-alerts/src/app/service/data-source.ts ---
@@ -0,0 +1,62 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r126532195
--- Diff: metron-interface/metron-alerts/src/app/model/search-request.ts ---
@@ -0,0 +1,7 @@
+export class SearchRequest {
+ _source: string
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r126531609
--- Diff:
metron-interface/metron-alerts/src/app/alerts/saved-searches/saved-searches.component.ts
---
@@ -0,0 +1,124 @@
+import { Component, OnInit
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r126531076
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/query-builder.ts ---
@@ -0,0 +1,139 @@
+/**
+ * Licensed to the Apache
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/636
The core issue is that both Solr and Elasticsearch depend on Lucene. Our
version of Elasticsearch (2.3.3) is old so there are lots of Lucene class
version conflicts when adding Solr
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/636
METRON-1022: Elasticsearch REST endpoint
## Contributor Comments
The PR adds a simple Elasticsearch REST endpoint that can execute simple
queries. This will serve as the foundation
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/635#discussion_r125913966
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/635#discussion_r125910236
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/ElasticsearchIndexingIntegrationTest.java
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/635
METRON-1018: Integration tests should reference flux yaml and property
files deployed by Ambari
## Contributor Comments
This PR makes a couple of improvements to our integration tests
GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/634
METRON-1017: Ambari components should be separate
## Contributor Comments
This PR separates the various configurations in Ambari into different
*-env.xml files. Doing this allows us
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/624
+1. Really nice job guys. Looking forward to working builds again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/624#discussion_r125037580
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
---
@@ -61,6 +62,7
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/624#discussion_r124927666
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java
---
@@ -61,6 +62,7
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/620
Here's an idea to get us started. A search request could look like:
```
{
"query": "ip_src_addr:192.168.66.1",
"from": 0,
"size":
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/624#discussion_r124869167
--- Diff:
metron-platform/metron-elasticsearch/src/test/java/org/apache/metron/elasticsearch/integration/components/ElasticSearchComponent.java
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/624
I'm spinning it up now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/620
If you want to make it specific to 'Alert' then I'm fine with that. I'm
not crazy about 'AlertsDTO', would prefer to keep the search result context in
the name, something like
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/620
Just tested again and I am able to now remove the first filter and properly
filter on values with special characters (referrer field for example). I did
another pass and found some trivial issues
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r124629201
--- Diff:
metron-interface/metron-alerts/src/app/shared/metron-table/metron-table-pagination/metron-table-pagination.component.scss
---
@@ -0,0 +1,30
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r124629155
--- Diff:
metron-interface/metron-alerts/src/app/shared/metron-table/metron-table-pagination/metron-table-pagination.component.html
---
@@ -0,0 +1,20
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/620#discussion_r124628897
--- Diff:
metron-interface/metron-alerts/src/app/shared/list-group/list-group.component.scss
---
@@ -0,0 +1,29 @@
+/**
+ * Licensed to the Apache
301 - 400 of 453 matches
Mail list logo
