Re: [DISCUSS] Coding style via checkstyle

I went ahead and created a couple tickets based on this discussion. https://issues.apache.org/jira/browse/METRON-746 https://issues.apache.org/jira/browse/METRON-747 Justin On Wed, Feb 22, 2017 at 9:16 AM, Casey Stella wrote: > +1 to longer line lengths, beer on fridays

Re: [DISCUSS] Coding style via checkstyle

+1 to longer line lengths, beer on fridays and mother's apple pie. On Wed, Feb 22, 2017 at 5:01 AM, Kyle Richardson wrote: > +1 to longer line lengths and blanket reformatting. Personally, I see IDE > integration as a must for adoption of checkstyle. > > -Kyle > > On

Re: [DISCUSS] Coding style via checkstyle

+1 to longer line lengths and blanket reformatting. Personally, I see IDE integration as a must for adoption of checkstyle. -Kyle On Wed, Feb 22, 2017 at 1:39 AM, Matt Foley wrote: > +1, so do I. Also like the idea of providing the necessary IntelliJ > specification. > > On

Re: [DISCUSS] Coding style via checkstyle

+1, so do I. Also like the idea of providing the necessary IntelliJ specification. On 2/21/17, 1:25 PM, "Otto Fowler" wrote: +1. I agree with Michael’s points. On February 21, 2017 at 16:23:21, Michael Miklavcic ( michael.miklav...@gmail.com) wrote:

Re: [DISCUSS] Coding style via checkstyle

I do like the idea of extending the line length to greater than 80. On Tue, Feb 21, 2017 at 6:29 PM, Justin Leet wrote: > Correct. It's pretty easy to do, I tested the line length limit property > on my own (to be explicit, nobody has ever agreed to anything other than >

Re: [DISCUSS] Coding style via checkstyle

Justin, Just to clarify, the default Sun conventions don't abide fully to our style guide, correct? As you mention above, we would need to create a custom checkstyle.xml to handle "extended the character limit of a line past 80 and made it two space indents" On Tue, Feb 21, 2017 at 3:22 PM,

Re: [DISCUSS] Coding style via checkstyle

I would also like the idea configuration. On February 21, 2017 at 17:06:09, Casey Stella (ceste...@gmail.com) wrote: +1 to blanket reformat as well. On Tue, Feb 21, 2017 at 1:25 PM, Otto Fowler wrote: > +1. I agree with Michael’s points. > > > On February 21, 2017 at

Re: [DISCUSS] Coding style via checkstyle

+1 to blanket reformat as well. On Tue, Feb 21, 2017 at 1:25 PM, Otto Fowler wrote: > +1. I agree with Michael’s points. > > > On February 21, 2017 at 16:23:21, Michael Miklavcic ( > michael.miklav...@gmail.com) wrote: > > +1 to a blanket reformat, failed build for

Re: [DISCUSS] Coding style via checkstyle

+1 to a blanket reformat, failed build for improper formatting, and automated formatting. I strongly prefer to remove "thinking" from my code formatting and it has worked very well for me on large projects in the past. There is capability now in IntelliJ to work with Checkstyle as well.

Re: [DISCUSS] Coding style via checkstyle

I would be in favor of a blanket, reformat. Whether that is for the entire code base or one project at a time. Might be able to conquer and divide some of the heavy-lifting of testing, if we do a project at a time. But whichever way you think is easier. I'd be glad to help. On Tue, Feb 21,

Re: [DISCUSS] Coding style via checkstyle

Oh, you already said you added it to 'site'. Sure enough. Ignore me. On Tue, Feb 21, 2017 at 2:26 PM, Nick Allen wrote: > There's probably also a discussion about how exactly we want to enforce it. >> Is it just something we add to the PR checklist and have reviewers give

Re: [DISCUSS] Coding style via checkstyle

> > There's probably also a discussion about how exactly we want to enforce it. > Is it just something we add to the PR checklist and have reviewers give a > glance, do we setup a hook to autoformat code, etc? I would prefer to see it fail the CI build, instead of relying on manual inspection or

Re: [DISCUSS] Coding style via checkstyle

I already tried a blanket, manual reformat the other day, through IntelliJ. I did every file matching *.java in the project and it was pretty quick. I didn't validate everything looked perfect afterwards, but I did click into a few files and things looked fine. I'm not quite sure what the

Re: [DISCUSS] Coding style via checkstyle

Any idea, with those modifications to checkstyle, how much effort it will take to reformat the code to conform? On Tue, Feb 21, 2017 at 8:23 AM, Justin Leet wrote: > As part of: > https://issues.apache.org/jira/browse/METRON-726 >

[DISCUSS] Coding style via checkstyle

As part of: https://issues.apache.org/jira/browse/METRON-726 https://github.com/apache/incubator-metron/pull/459 I integrated checkstyle into the mvn:site command, and have checkstyle reports being run as part of the mvn:site reporting. I expect to be celebrating hitting 25k checkstyle warnings