Serial Transport reintegration in TRUNK or not

2008-05-21 Thread Julien Vermillard
Hi, The serial transport module, a transport implementation, using serial port (RS232) was moved to sandbox due to licences issues. Here a simple resume : the serial transport use the RXTX, a java serial communication lib. The problem is that RXTX is LGPL licensed. You would may so ask so what's

Re: Serial Transport reintegration in TRUNK or not

2008-05-21 Thread Maarten Bosteels
Hi Julien, I'd prefer solution #2 but I could also live with #1 regards Maarten On Wed, May 21, 2008 at 8:58 AM, Julien Vermillard [EMAIL PROTECTED] wrote: Hi, The serial transport module, a transport implementation, using serial port (RS232) was moved to sandbox due to licences issues.

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Eero Nevalainen
Emmanuel Lecharny wrote: 이희승 (Trustin Lee) wrote: On Wed, 21 May 2008 10:08:27 +0900, Emmanuel Lecharny [EMAIL PROTECTED] wrote: Another things would also be to get a byte[] getBytes( in length ) method returning as much bytes as possible, up to a length. If the number of available bytes is

[jira] Updated: (DIRMINA-489) Composite IoBuffer

2008-05-21 Thread Rich Dougherty (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rich Dougherty updated DIRMINA-489: --- Attachment: mina-composite-20080521-2.patch This patch is against the code in the 'buffer

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Rich Dougherty
On Wed, May 21, 2008 at 9:36 AM, 이희승 (Trustin Lee) [EMAIL PROTECTED] wrote: On Tue, 20 May 2008 22:56:03 +0900, Daniel Wirtz [EMAIL PROTECTED] wrote: And what about slicing contents from the buffer? Does it *copy* the contents to a new bytebuffer or is a composite buffer used in the

Re: What do you think of this proposed change?

2008-05-21 Thread Gaston Dombiak
Hey Trustin, Latest version we were using was 1.1.6 so I’m now checking the changes made for 1.1.7 and later. I found that IoServiceListenerSupport in line 164 is using ifAbsentPut. BTW, that brought some flashbacks from my Smalltalk dev experience. :) However, in Java the implementation is

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Emmanuel Lecharny
이희승 (Trustin Lee) wrote: Would be better to returns what has already been read. Sometime, you are just proxying the data, and you want to send it to the next consumer as soon as you get some. Otherwise, the queue will buffer potentially gigantic data in memory. (This is something we

Re: A big problem: SocketConnector blocked!

2008-05-21 Thread Michael Qi
Why is there is one selector per SocketConnector? Could it be reused system wide? On Tue, May 20, 2008 at 9:19 AM, 이희승 (Trustin Lee) [EMAIL PROTECTED] wrote: Please provide a working test application, instead of partial code. On Mon, 19 May 2008 22:43:46 +0900, Michael Qi [EMAIL PROTECTED]

Re: A big problem: SocketConnector blocked!

2008-05-21 Thread Julien Vermillard
With using 1 SocketConnector for connecting 100 sessionqs, you will share 1 selector among the 100 sessions. Julien On Wed, 21 May 2008 20:53:05 +0800 Michael Qi [EMAIL PROTECTED] wrote: Why is there is one selector per SocketConnector? Could it be reused system wide? On Tue, May 20, 2008

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Daniel Wirtz
On Wed, May 21, 2008 at 11:00 AM, Eero Nevalainen [EMAIL PROTECTED] wrote: I think that the above use case works fine when using heap buffers, as when there are no more references to the message object the sliced buffers should be freed as well. But would I need to do something extra to make

Re: MINA + Grizzly discussion

2008-05-21 Thread Jeanfrancois Arcand
Hi, before we can have the discussion, I need to make sure every body agree (all other commiters :-)) to start a discussion on the grizzly side. So gives me a couple of days :-) [cut] agreed. We could talk about: * the possibility of merging two projects in the future (not sure this

Re: MINA + Grizzly discussion

2008-05-21 Thread Julien Vermillard
Hi, First great to hear you ! On Wed, 21 May 2008 09:44:00 -0400 Jeanfrancois Arcand [EMAIL PROTECTED] wrote: Hi, before we can have the discussion, I need to make sure every body agree (all other commiters :-)) to start a discussion on the grizzly side. So gives me a couple of days :-)

Re: MINA + Grizzly discussion

2008-05-21 Thread Emmanuel Lecharny
Hi Jean-François, Jeanfrancois Arcand wrote: Hi, before we can have the discussion, I need to make sure every body agree (all other commiters :-)) to start a discussion on the grizzly side. So gives me a couple of days :-) No problem. We are not in a hurry ! I will add: + Have a new JSR

Re: MINA + Grizzly discussion

2008-05-21 Thread Mark Webb
Jeanfrancois, Welcome. I have been a big fan of your work and have enjoyed your blog over the years. I will say that I am one of the 'young' ASF members on the MINA team and welcome any synergies that will be created as a result of us coming together. --Mark On Wed, May 21, 2008 at 9:57 AM,

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Rich Dougherty
Hi Daniel Although MINA probably *uses* buffers for short periods of time, wouldn't it be possible to make the underlying buffers long-lived by pooling them between usages? Of course, if we pooled buffers then we'd need to support some mechanism of returning the buffers to the pool (probably an

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Emmanuel Lecharny
Rich Dougherty wrote: Hi Daniel Although MINA probably *uses* buffers for short periods of time, wouldn't it be possible to make the underlying buffers long-lived by pooling them between usages? Of course, if we pooled buffers then we'd need to support some mechanism of returning the buffers to

RE: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Outside - Karl's ACM
With respect, I would disagree with generalizations made from this excerpt in the javadoc. The important reason given in the javadoc is that allocation and freeing of direct buffers are more costly than the trivial cost of allocating a heap buffer. I am confident that this is true in all cases

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Daniel Wirtz
Hello Rich, Although MINA probably *uses* buffers for short periods of time, wouldn't it be possible to make the underlying buffers long-lived by pooling them between usages? Of course, if we pooled buffers then we'd need to support some mechanism of returning the buffers to the pool

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Emmanuel Lecharny
Outside - Karl's ACM wrote: With respect, I would disagree with generalizations made from this excerpt in the javadoc. The important reason given in the javadoc is that allocation and freeing of direct buffers are more costly than the trivial cost of allocating a heap buffer. This is not eactly

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Daniel Wirtz
Hello karl, If we have interest in the hypothesis that copy-avoidance/zero-copy will realize broad server throughput advantages, then it may be more efficient overall to allocate direct buffers, process our bytes, and explicitly free the direct buffers. This removes a possibly heavy burden

RE: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Pauls, Karl
-Original Message- From: Daniel Wirtz [mailto:[EMAIL PROTECTED] Yes they have, but only if there is a way to pass some memory contents from one to another application (or the OS). To take advantage of this, we may need to hack the JVM and maybe the OS's network implementation I

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Daniel Wirtz
On Wed, May 21, 2008 at 11:10 PM, Pauls, Karl [EMAIL PROTECTED] wrote: If I understand you correctly, then apart from the kernel-level implications of zero-copy reads, such a facility to bring bytes into the JVM without a copy has existed in the JNI spec since Java 1.4.

Re: ConnectionThrottleFilter

2008-05-21 Thread Daniel Wirtz
2008/5/21 Steve Johns [EMAIL PROTECTED]: Any hardware like firewall does the trick? A hardware firewall will also use the remote address. This is a problem caused by the nature of NAT. I also don't see a clean solution to make a difference between clients that reside behind a NAT, so the Mina

Re: ConnectionThrottleFilter

2008-05-21 Thread Steve Johns
1) We maybe assume that kind of clients won't connect to server at same time. However, what about server got restarted with clients reconnect at same time? Load the connection filter after server starts 10 mins? ^^ 2) Never use connection filter and we assume there is no such a malicious attack?

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Trustin Lee
On Thu, 22 May 2008 05:14:24 +0900, Emmanuel Lecharny [EMAIL PROTECTED] wrote: Rich Dougherty wrote: Hi Daniel Although MINA probably *uses* buffers for short periods of time, wouldn't it be possible to make the underlying buffers long-lived by pooling them between usages? Of course, if

Re: ConnectionThrottleFilter

2008-05-21 Thread Daniel Wirtz
On Thu, May 22, 2008 at 12:51 AM, Steve Johns [EMAIL PROTECTED] wrote: 1) We maybe assume that kind of clients won't connect to server at same time. However, what about server got restarted with clients reconnect at same time? Load the connection filter after server starts 10 mins? ^^

Re: MINA + Grizzly discussion

2008-05-21 Thread Trustin Lee
Hi JF, Please feel free to take your time. :) On Wed, 21 May 2008 22:44:00 +0900, Jeanfrancois Arcand [EMAIL PROTECTED] wrote: Hi, before we can have the discussion, I need to make sure every body agree (all other commiters :-)) to start a discussion on the grizzly side. So gives me a

JavaDoc added to org.apache.mina.queue

2008-05-21 Thread Trustin Lee
Hi folks, I've just added JavaDoc to the classes in org.apache.mina.queue package to make sure we understood the semantic of all operations correctly: * http://svn.apache.org/viewvc/mina/branches/buffer/core/src/main/java/org/apache/mina/queue/ A little bit of documentation was copied

Re: Feed back appreciated - Quick preview of buffer rewrite

2008-05-21 Thread Emmanuel Lecharny
이희승 (Trustin Lee) wrote: On Thu, 22 May 2008 05:14:24 +0900, Emmanuel Lecharny [EMAIL PROTECTED] wrote: Rich Dougherty wrote: Hi Daniel Although MINA probably *uses* buffers for short periods of time, wouldn't it be possible to make the underlying buffers long-lived by pooling them

Re: A big problem: SocketConnector blocked!

2008-05-21 Thread Michael Qi
Hi Lee, I could not send the application, the gmail server report failure. Could I send it direct to your gmail address? Regards HeQi On Tue, May 20, 2008 at 9:19 AM, 이희승 (Trustin Lee) [EMAIL PROTECTED] wrote: Please provide a working test application, instead of partial code. On Mon, 19