About MINA commits with some code refactoring

2009-06-29 Thread Emmanuel Lecharny
Hi guys, recently I saw some commits on MINA where some code has been refactored (like lines were limited to 80 caracters, stuff like that). I don't think it's a bad thing to do code refactoring, but the problem is that when it's mixed with some code addition, it buries the fixes into a lot

Re: About MINA commits with some code refactoring

2009-06-29 Thread Julien Vermillard
Le Mon, 29 Jun 2009 11:08:33 +0200, Emmanuel Lecharny elecha...@apache.org a écrit : Hi guys, recently I saw some commits on MINA where some code has been refactored (like lines were limited to 80 caracters, stuff like that). I don't think it's a bad thing to do code refactoring, but the

Re: svn commit: r789164 - /mina/trunk/core/src/main/java/org/apache/mina/core/service/SimpleIoProcessorPool.java

2009-06-29 Thread Julien Vermillard
Hi, Interesting optimization. The idea is to make SimpleIoPPool instantiation faster ? Julien On Mon, Jun 29, 2009 at 12:30 AM, edeolive...@apache.org wrote: Author: edeoliveira Date: Sun Jun 28 22:30:02 2009 New Revision: 789164 URL: http://svn.apache.org/viewvc?rev=789164view=rev Log:

[jira] Commented: (FTPSERVER-315) Pass FtpSession information to the UserManager.authenticate method

2009-06-29 Thread Sai Pullabhotla (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12725145#action_12725145 ] Sai Pullabhotla commented on FTPSERVER-315: --- Another reason where this change

[jira] Commented: (FTPSERVER-315) Pass FtpSession information to the UserManager.authenticate method

2009-06-29 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12725150#action_12725150 ] Niklas Gustavsson commented on FTPSERVER-315: - The client certificate chain

Re : svn commit: r789164 - /mina/trunk/core/src/main/java/org/apache/mina/core/service/SimpleIoProcessorPool.java

2009-06-29 Thread Edouard De Oliveira
Yes in previous version each constructor type was tested again and again in the loop The new code is slightly more complex but it is based on the fact that we need at least one processor so we discover which constructor to use and then we loop and use the previously determined constructor.

Re : About MINA commits with some code refactoring

2009-06-29 Thread Edouard De Oliveira
+1 You're perfectly right to prefer spam instead of difficult commits to read ^^ Cordialement, Regards, -Edouard De Oliveira- Blog: http://tedorgwp.free.fr WebSite: http://tedorg.free.fr/en/main.php - Message d'origine De : Julien Vermillard jvermill...@archean.fr À :

Re: Re : About MINA commits with some code refactoring

2009-06-29 Thread Emmanuel Lecharny
Edouard De Oliveira wrote: +1 You're perfectly right to prefer spam instead of difficult commits to read ^^ Just for my information, which IDE are you using ? -- -- cordialement, regards, Emmanuel Lécharny www.iktek.com directory.apache.org

Re : Re : About MINA commits with some code refactoring

2009-06-29 Thread Edouard De Oliveira
Eclipse and i do use the convention formatting file usually i work under windows but in the past two weeks i've been using it in sun's virtualbox running latest ubuntu Cordialement, Regards, -Edouard De Oliveira- Blog: http://tedorgwp.free.fr WebSite: http://tedorg.free.fr/en/main.php -

Re: [jira] Commented: (FTPSERVER-315) Pass FtpSession information to the UserManager.authenticate method

2009-06-29 Thread Sai Pullabhotla
Thanks, Niklas. I thought there was something like that, but overlooked. Sai Pullabhotla www.jMethods.com On Mon, Jun 29, 2009 at 7:25 AM, Niklas Gustavsson (JIRA) j...@apache.orgwrote: [