Re: final keyword : can we get rid of it when it's not necessary ?

2013-01-31 Thread Maarten Bosteels
I think a) that all instance fields that *can* be immutable *should* be immutable (helps a lot in making sure the code is thread-safe) b) that all instance fields that are supposed to be immutable should be declared as final, IMO it makes the code *more* readable I usually don't declare local

[jira] [Commented] (DIRMINA-925) Unresponsive I/O once file limit is reached

2013-01-31 Thread Maarten Bosteels (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567747#comment-13567747 ] Maarten Bosteels commented on DIRMINA-925: -- We have had similar issues. It's

[jira] [Updated] (SSHD-208) TCPIP forwarders should send CLOSE not EOF

2013-01-31 Thread Andrew C (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew C updated SSHD-208: -- Attachment: sshd-208.patch Proposed fix. TCPIP forwarders should send CLOSE not EOF

[jira] [Commented] (DIRMINA-925) Unresponsive I/O once file limit is reached

2013-01-31 Thread Paul Gregoire (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13567797#comment-13567797 ] Paul Gregoire commented on DIRMINA-925: --- Agreed Maarten and we've done the same

Re: Opinion on this Java IO bug

2013-01-31 Thread Emmanuel Lécharny
Le 1/31/13 5:52 PM, Mondain a écrit : I was talking to Jon Valliere this morning about GC with IOPS and I wondered what the opinion of the Mina dev team is on this issue: http://bugs.sun.com/bugdatabase/view_bug.do;jsessionid=ca40fa265e28a3ccb91527b258ff?bug_id=6924217 How well is this handled

[jira] [Updated] (SSHD-208) TCPIP forwarders should send CLOSE not EOF

2013-01-31 Thread Andrew C (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew C updated SSHD-208: -- Attachment: sshd-208.patch Revised patch; also remove handleEof() from TcpipCLientChannel

[jira] [Updated] (SSHD-206) Race between SSH_MSG_CHANNEL_DATA and SSH_MSG_CHANNEL_CLOSE in ChannelForwardedTcpip?

2013-01-31 Thread Andrew C (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew C updated SSHD-206: -- Attachment: sshd-206.patch Proposed fix. The eof variable shouldn't be checked as it indicates that the remote

[jira] [Updated] (SSHD-202) SSH Client silently accepts server key by default :-(

2013-01-31 Thread Andrew C (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew C updated SSHD-202: -- Attachment: sshd-202.patch As proposed. SSH Client silently accepts server key by default :-(

Re: Opinion on this Java IO bug

2013-01-31 Thread Mondain
I'll see if I can get some unit tests together to possibly locate anything that may be leaking in Mina 2.0.8. On Thu, Jan 31, 2013 at 8:57 AM, Emmanuel Lécharny elecha...@gmail.comwrote: Le 1/31/13 5:52 PM, Mondain a écrit : I was talking to Jon Valliere this morning about GC with IOPS and I

Re: Opinion on this Java IO bug

2013-01-31 Thread Emmanuel Lécharny
Le 1/31/13 7:46 PM, Mondain a écrit : I'll see if I can get some unit tests together to possibly locate anything that may be leaking in Mina 2.0.8. What would be interesting is to runa profiler to see if we have some memory leaks. Regarding the reported 'bug', this is clearly not a bug, but a