[jira] [Commented] (SSHD-803) SSHD port forwarding. Missing SSH_MSG_CHANNEL_EOF

2018-02-11 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360369#comment-16360369 ] Goldstein Lyor commented on SSHD-803: - I have committed the changes you suggested for the

[jira] [Commented] (SSHD-803) SSHD port forwarding. Missing SSH_MSG_CHANNEL_EOF

2018-02-11 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360346#comment-16360346 ] Goldstein Lyor commented on SSHD-803: - [~fcava] I have read some more about the {{SSH_MSG_CHANNEL_EOF}}

[jira] [Assigned] (SSHD-803) SSHD port forwarding. Missing SSH_MSG_CHANNEL_EOF

2018-02-11 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor reassigned SSHD-803: --- Assignee: Goldstein Lyor > SSHD port forwarding. Missing SSH_MSG_CHANNEL_EOF >

[jira] [Comment Edited] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360060#comment-16360060 ] Jonathan Valliere edited comment on DIRMINA-1076 at 2/12/18 12:38 AM:

[jira] [Comment Edited] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360060#comment-16360060 ] Jonathan Valliere edited comment on DIRMINA-1076 at 2/12/18 12:37 AM:

Re: Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
Look at my patch notes for Christoph’s dispose bug in JIRA DIRMINA-1076I fixed the negative counter problem but want to add a critical check Incase it ever reappears. On Sun, Feb 11, 2018 at 5:15 PM Emmanuel Lécharny wrote: > > > Le 11/02/2018 à 19:14, Jonathan Valliere a

Re: Fatal Error Handling

2018-02-11 Thread Emmanuel Lécharny
Le 11/02/2018 à 19:14, Jonathan Valliere a écrit : > There is a condition in the IoProcessor where the expected Session Count > turns negative. Basically the IoProcessor is now in a Fatal state. What > should happen? Uh oH... The expected Session count should *never* become negative. If it's

Re: Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
There is a condition in the IoProcessor where the expected Session Count turns negative. Basically the IoProcessor is now in a Fatal state. What should happen? On Sun, Feb 11, 2018 at 12:55 PM Emmanuel Lécharny wrote: > > > Le 11/02/2018 à 15:52, Jonathan Valliere a écrit :

Re: Fatal Error Handling

2018-02-11 Thread Emmanuel Lécharny
Le 11/02/2018 à 15:52, Jonathan Valliere a écrit : > Hi Team, > > What is the standard way in Mina of handing super fatal errors? i.e. > unrecoverable invalid internal state Exception are trapped and probagated to the application through the ExcetionCaught message, the session being closed in

[jira] [Commented] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359966#comment-16359966 ] Jonathan Valliere commented on DIRMINA-1076: Here is the patch to fix your issue; it also

[jira] [Updated] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1076: --- Attachment: (was: christoph-hanging-dispose.patch) > Leaking

[jira] [Updated] (DIRMINA-1076) Leaking NioProcessors/NioSocketConnectors hanging in call to dispose

2018-02-11 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1076: --- Attachment: christoph-hanging-dispose.patch > Leaking

Fatal Error Handling

2018-02-11 Thread Jonathan Valliere
Hi Team, What is the standard way in Mina of handing super fatal errors? i.e. unrecoverable invalid internal state Right now, I added an `assert` statement but that probably isn’t good enough.