[jira] [Resolved] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor resolved SSHD-835. - Resolution: Fixed [~gnt] Marking the issue as resolved - I have made a few structural changes:

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556881#comment-16556881 ] Goldstein Lyor commented on SSHD-835: - {quote} I haven't implemented the ClosingExecutor because

[jira] [Comment Edited] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556831#comment-16556831 ] Guillaume Nodet edited comment on SSHD-835 at 7/26/18 3:21 AM: --- I haven't

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556831#comment-16556831 ] Guillaume Nodet commented on SSHD-835: -- I haven't implemented the `ClosingExecutor` because there's no

[jira] [Comment Edited] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556142#comment-16556142 ] Goldstein Lyor edited comment on SSHD-835 at 7/25/18 7:07 PM: -- Seems

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556142#comment-16556142 ] Goldstein Lyor commented on SSHD-835: - Seems reasonable - although after reviewing the code I would

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555803#comment-16555803 ] Goldstein Lyor commented on SSHD-835: - [~gnt] I have looked at the code and it seems that most

[jira] [Reopened] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor reopened SSHD-835: - > Introduce a Closeable ExecutorService > - > >

[jira] [Resolved] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved SSHD-835. -- Resolution: Fixed > Introduce a Closeable ExecutorService >

[jira] [Resolved] (SSHD-836) Make final some methods from base Closeable implementations

[ https://issues.apache.org/jira/browse/SSHD-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved SSHD-836. -- Resolution: Fixed > Make final some methods from base Closeable implementations >

[jira] [Updated] (SSHD-836) Make final some methods from base Closeable implementations

[ https://issues.apache.org/jira/browse/SSHD-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated SSHD-836: - Fix Version/s: 2.1.0 > Make final some methods from base Closeable implementations >

[jira] [Commented] (SSHD-340) Hanging threads left working when server is shut down

[ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555852#comment-16555852 ] Jared Wiltshire commented on SSHD-340: -- [~gnt] Thanks for clearing that up. If its not intended to be

[jira] [Comment Edited] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555817#comment-16555817 ] Guillaume Nodet edited comment on SSHD-835 at 7/25/18 3:19 PM: --- There are

[jira] [Commented] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555817#comment-16555817 ] Guillaume Nodet commented on SSHD-835: -- There are multiple benefits: - remove the need to carry the

[jira] [Comment Edited] (SSHD-340) Hanging threads left working when server is shut down

[ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1658#comment-1658 ] Guillaume Nodet edited comment on SSHD-340 at 7/25/18 12:02 PM: Hopefully

[jira] [Commented] (SSHD-340) Hanging threads left working when server is shut down

[ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1658#comment-1658 ] Guillaume Nodet commented on SSHD-340: -- Hopefully both issues will help. > Hanging threads left

[jira] [Created] (SSHD-836) Make final some methods from base Closeable implementations

Guillaume Nodet created SSHD-836: Summary: Make final some methods from base Closeable implementations Key: SSHD-836 URL: https://issues.apache.org/jira/browse/SSHD-836 Project: MINA SSHD

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555608#comment-16555608 ] Guus der Kinderen commented on DIRMINA-1078: Thanks! Please note that for Java 10, the

[jira] [Commented] (DIRMINA-1088) OrderedThreadPool implementation should be compatible with Java 10

[ https://issues.apache.org/jira/browse/DIRMINA-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555606#comment-16555606 ] Guus der Kinderen commented on DIRMINA-1088: [~elecharny], would you mind applying the same

[jira] [Assigned] (SSHD-836) Make final some methods from base Closeable implementations

[ https://issues.apache.org/jira/browse/SSHD-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned SSHD-836: Assignee: Guillaume Nodet > Make final some methods from base Closeable implementations >

[jira] [Updated] (SSHD-835) Introduce a Closeable ExecutorService

[ https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated SSHD-835: - Fix Version/s: 2.1.0 > Introduce a Closeable ExecutorService >

[jira] [Created] (SSHD-835) Introduce a Closeable ExecutorService

Guillaume Nodet created SSHD-835: Summary: Introduce a Closeable ExecutorService Key: SSHD-835 URL: https://issues.apache.org/jira/browse/SSHD-835 Project: MINA SSHD Issue Type: Improvement

[jira] [Commented] (SSHD-340) Hanging threads left working when server is shut down

[ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555414#comment-16555414 ] Goldstein Lyor commented on SSHD-340: - I defer to your judgment here - please revert the change I made

[jira] [Commented] (SSHD-340) Hanging threads left working when server is shut down

[ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555338#comment-16555338 ] Goldstein Lyor commented on SSHD-340: - {quote} For example Nio2ServiceFactory does perform a

[jira] [Commented] (SSHD-340) Hanging threads left working when server is shut down

[ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555357#comment-16555357 ] Guillaume Nodet commented on SSHD-340: -- I don't think this is a good idea to allow restarting a closed

[jira] [Commented] (SSHD-340) Hanging threads left working when server is shut down

[ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555194#comment-16555194 ] Goldstein Lyor commented on SSHD-340: - I added a reset of the state back to {{Opened}} if server

[GitHub] mina-sshd pull request #64: Improve missing resource exception message

Github user jamesnetherton closed the pull request at: https://github.com/apache/mina-sshd/pull/64 ---