[jira] [Work started] (SSHD-912) Review usages of AbstractCloseable#lock and constrain them only to actually needed ones

2019-04-30 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on SSHD-912 started by Goldstein Lyor. --- > Review usages of AbstractCloseable#lock and constrain them only to actually > nee

[jira] [Resolved] (SSHD-911) Deadlock in Apache SshClient used for local port forwarding

2019-04-30 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor resolved SSHD-911. - Resolution: Fixed Fix Version/s: 2.3.0 [~roberto.deandrea] Marking this issue as fixed - let

[GitHub] [mina-sshd] lgoldstein opened a new pull request #102: [SSHD-912] Use separate locks for Future(s) and Session/Channel instances

2019-04-30 Thread GitBox
lgoldstein opened a new pull request #102: [SSHD-912] Use separate locks for Future(s) and Session/Channel instances URL: https://github.com/apache/mina-sshd/pull/102 This is an automated message from the Apache Git Service.

[jira] [Work logged] (SSHD-912) Review usages of AbstractCloseable#lock and constrain them only to actually needed ones

2019-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-912?focusedWorklogId=235379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235379 ] ASF GitHub Bot logged work on SSHD-912: --- Author: ASF GitHub Bot

[jira] [Commented] (SSHD-912) Review usages of AbstractCloseable#lock and constrain them only to actually needed ones

2019-04-30 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830442#comment-16830442 ] Goldstein Lyor commented on SSHD-912: - [~roberto.deandrea] I have made some changes - p

Please review suggested PR for SSHD-912

2019-04-30 Thread Lyor Goldstein
https://github.com/apache/mina-sshd/pull/102 This PR involves some changes to very crucial mutual exclusion and signalling locks so I would like to be sure that (a) nothing was missed and (b) no deadlocks were introduced (beyond what SSHD-911 and SSHD-912 seem to indicate) For those who want - y