[jira] [Commented] (SSHD-660) Add support for authentication using signed client/server keys

2020-04-14 Thread Lyor Goldstein (Jira)
[ https://issues.apache.org/jira/browse/SSHD-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083517#comment-17083517 ] Lyor Goldstein commented on SSHD-660: - I reviewed it and had some comments - seems lik

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408351310 ## File path: sshd-core/src/main/java/org/apache/sshd/client/kex/DHGClient.java ## @@ -124,10 +129,6

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408348176 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/impl/OpenSSHCertificateDecoder.jav

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408350789 ## File path: sshd-core/src/main/java/org/apache/sshd/client/kex/DHGClient.java ## @@ -124,10 +129,6

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408350307 ## File path: sshd-core/src/main/java/org/apache/sshd/client/kex/DHGClient.java ## @@ -124,10 +129,6

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408341522 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java #

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408343089 ## File path: sshd-common/src/main/java/org/apache/sshd/common/config/keys/OpenSshCertificate.java #

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408343763 ## File path: sshd-common/src/main/java/org/apache/sshd/common/keyprovider/FileHostKeyCertificateProvider.jav

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408344301 ## File path: sshd-common/src/main/java/org/apache/sshd/common/keyprovider/FileHostKeyCertificateProvider.jav

[GitHub] [mina-sshd] lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates

2020-04-14 Thread GitBox
lgoldstein commented on a change in pull request #119: Add support for openssh host key certificates URL: https://github.com/apache/mina-sshd/pull/119#discussion_r408345027 ## File path: sshd-common/src/main/java/org/apache/sshd/common/keyprovider/KeyPairProvider.java ##