gnodet opened a new pull request #121: Autoformat source code
URL: https://github.com/apache/mina-sshd/pull/121
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Unless there's a strong objection, i'll soon commit the changes in
https://github.com/apache/mina-sshd/pull/121 which do autoformat the code.
This makes the development process much smoother as the code is
automatically reformatted, so that you don't have to fix the problems later
in the cycle. Of
>> Unless there's a strong objection, i'll soon commit the changes in
I have no strong objection, but I am a bit confused why this is better than
checkstyle. Please bear in mind that checkstyle is not only about
indentations but also imposes what are currently considered good practices
(e.g., max
lgoldstein commented on issue #121: Autoformat source code
URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616136907
I am not sure how this change is supposed to work
* Does one commit changes only after the build ? I find this slightly
counter-intuitive as it means t
gnodet commented on issue #121: Autoformat source code
URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616142503
> I am not sure how this change is supposed to work
>
> * Does one commit changes only after the build ? I find this slightly
counter-intuitive as it means
[
https://issues.apache.org/jira/browse/SSHD-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087027#comment-17087027
]
FliegenKLATSCH commented on SSHD-895:
-
Hm.. if it is like this, would it not get really
lgoldstein commented on issue #121: Autoformat source code
URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616144959
>> All formatting rules can be changed at will using the
sshd-eclipse-formatter-config.xml config file in the root.
What about Intellij ? Is it affected
[
https://issues.apache.org/jira/browse/SSHD-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087035#comment-17087035
]
Lyor Goldstein commented on SSHD-895:
-
{quote}m.. if it is like this, would it not get
FliegenKLATSCH opened a new pull request #122: Allow colon as valid host
pattern char to support ipv6 entries in kno…
URL: https://github.com/apache/mina-sshd/pull/122
…wn_hosts (SSHD-745)
This is an automated message from th
gnodet commented on issue #121: Autoformat source code
URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616161282
> > > All formatting rules can be changed at will using the
sshd-eclipse-formatter-config.xml config file in the root.
>
> What about Intellij ? Is it affec
lgoldstein commented on issue #121: Autoformat source code
URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616163814
>> Not sure what you refer to exactly here. I think the formatting takes
into accounts all style related rules, spaces, braces, indentation, etc... You
may ha
lgoldstein commented on issue #122: Allow colon as valid host pattern char to
support ipv6 entries in kno…
URL: https://github.com/apache/mina-sshd/pull/122#issuecomment-616164183
Please add some unit tests and I will merge it...
[
https://issues.apache.org/jira/browse/SSHD-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087054#comment-17087054
]
Lyor Goldstein commented on SSHD-981:
-
Can you add a link to some documentation as to t
gnodet commented on issue #121: Autoformat source code
URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616168471
> > > Not sure what you refer to exactly here. I think the formatting takes
into accounts all style related rules, spaces, braces, indentation, etc... You
may hav
lgoldstein commented on issue #121: Autoformat source code
URL: https://github.com/apache/mina-sshd/pull/121#issuecomment-616169023
>> Ok, we can easily keep those, I don't have any problems with that. The
ones that are problematic to me are mostly the styling ones.
I can live with t
lgoldstein commented on issue #119: Add support for openssh host key
certificates
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-616170892
Merged with acknowledgement and many thanks (see
[47f779f06cb345c7cb706cb81f1214c37dab1fda](https://github.com/apache/mina-sshd/commit/
FliegenKLATSCH commented on issue #119: Add support for openssh host key
certificates
URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-616178697
Thanks a lot, but it's not only server side support but also client side (I
started with client side actually and had two different
I think your forgot to commit the changes to a few files: KeyUtils,
KeyPairProvider
Le dim. 19 avr. 2020 à 18:00, a écrit :
> This is an automated email from the ASF dual-hosted git repository.
>
> lgoldstein pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/mi
18 matches
Mail list logo