Re: [PR] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]

2024-05-30 Thread via GitHub
JinHeap commented on PR #511: URL: https://github.com/apache/mina-sshd/pull/511#issuecomment-2141078742 thanks. then if need me do something, please tell me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]

2024-05-30 Thread via GitHub
tomaswolf commented on PR #511: URL: https://github.com/apache/mina-sshd/pull/511#issuecomment-2140908858 Thanks. The change is good, but now that this is fixed `DefaultIoServiceFactoryFactoryTest` hangs for MINA during disposal of the partially set up (with mocks) `MinaServiceFactory`.

[PR] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]

2024-05-30 Thread via GitHub
JinHeap opened a new pull request, #511: URL: https://github.com/apache/mina-sshd/pull/511 Addresses https://github.com/apache/mina-sshd/issues/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]

2024-05-30 Thread via GitHub
JinHeap commented on issue #510: URL: https://github.com/apache/mina-sshd/issues/510#issuecomment-2138824207 > Looks like an obvious bug. Probably this was missed in some earlier refactoring. Want to provide a PR? OK -- This is an automated message from the Apache Git Service. To

Re: [I] Fix mina full class name in BuiltinIoServiceFactoryFactories [mina-sshd]

2024-05-30 Thread via GitHub
tomaswolf commented on issue #510: URL: https://github.com/apache/mina-sshd/issues/510#issuecomment-2138815644 Looks like an obvious bug. Probably this was missed in some earlier refactoring. Want to provide a PR? -- This is an automated message from the Apache Git Service. To respond to