Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-29 Thread via GitHub
tomaswolf commented on PR #507: URL: https://github.com/apache/mina-sshd/pull/507#issuecomment-2137589316 Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-29 Thread via GitHub
tomaswolf merged PR #507: URL: https://github.com/apache/mina-sshd/pull/507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-29 Thread via GitHub
tomaswolf commented on PR #507: URL: https://github.com/apache/mina-sshd/pull/507#issuecomment-2136694291 Also in the newest change: when TIMEOUT is explicitly set <= 0 and NO_RELY_MAX is not set, set NO_REPLY_MAX to zero. -- This is an automated message from the Apache Git Service. To re

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-29 Thread via GitHub
tomaswolf commented on code in PR #507: URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1618319934 ## CHANGES.md: ## @@ -58,7 +59,39 @@ NTRU Prime sntrup761 and X25519 with SHA-512: sntrup761x25519-sha512](https://ww ## Behavioral changes and enhancements -*

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-28 Thread via GitHub
gnodet commented on code in PR #507: URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1617916399 ## sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java: ## @@ -55,7 +61,41 @@ public ClientConnectionService(AbstractClientSession s) th

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-28 Thread via GitHub
tomaswolf commented on code in PR #507: URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1617835398 ## CHANGES.md: ## @@ -58,7 +59,34 @@ NTRU Prime sntrup761 and X25519 with SHA-512: sntrup761x25519-sha512](https://ww ## Behavioral changes and enhancements -*

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-28 Thread via GitHub
tomaswolf commented on code in PR #507: URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1617834559 ## sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java: ## @@ -55,7 +61,40 @@ public ClientConnectionService(AbstractClientSession s)

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-28 Thread via GitHub
tomaswolf commented on code in PR #507: URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1617834382 ## sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java: ## @@ -55,7 +61,40 @@ public ClientConnectionService(AbstractClientSession s)

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-28 Thread via GitHub
tomaswolf commented on code in PR #507: URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1617834119 ## sshd-core/src/main/java/org/apache/sshd/core/CoreModuleProperties.java: ## @@ -162,10 +162,21 @@ public final class CoreModuleProperties { /** * Key use

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-28 Thread via GitHub
tomaswolf commented on code in PR #507: URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1617833708 ## sshd-core/src/main/java/org/apache/sshd/core/CoreModuleProperties.java: ## @@ -162,10 +162,21 @@ public final class CoreModuleProperties { /** * Key use

Re: [PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-28 Thread via GitHub
gnodet commented on code in PR #507: URL: https://github.com/apache/mina-sshd/pull/507#discussion_r1617742237 ## sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java: ## @@ -55,7 +61,40 @@ public ClientConnectionService(AbstractClientSession s) th

[PR] GH-461: Fix heartbeats with wantReply=true [mina-sshd]

2024-05-25 Thread via GitHub
tomaswolf opened a new pull request, #507: URL: https://github.com/apache/mina-sshd/pull/507 Switch from a timeout model to the OpenSSH model: fail if there are more than a certain number of heartbeats for which no reply was received yet. Fixes #461. -- This is an automated message