Re: Adding support for EnumSet to ByteBuffer

2007-06-11 Thread Mike Heath
On Mon, 2007-06-11 at 11:21 +0900, Trustin Lee wrote: > On 6/10/07, peter royal <[EMAIL PROTECTED]> wrote: > > On Jun 8, 2007, at 11:03 PM, Mike Heath wrote: > > > If this functionality is desired, I'll add some Java Docs to the above > > > methods and commit my code and accompanying unit tests. >

Re: Adding support for EnumSet to ByteBuffer

2007-06-11 Thread Trustin Lee
On 6/12/07, Mike Heath <[EMAIL PROTECTED]> wrote: On 6/10/07, Trustin Lee <[EMAIL PROTECTED]> wrote: > Additionally, the following features might make ByteBuffer more useful: > > * Provide getEnum and putEnum too. (just reading and writing the > ordinal value itself) > * Throw an IllegalArgument

Re: Adding support for EnumSet to ByteBuffer

2007-06-11 Thread Mike Heath
On 6/10/07, Trustin Lee <[EMAIL PROTECTED]> wrote: Additionally, the following features might make ByteBuffer more useful: * Provide getEnum and putEnum too. (just reading and writing the ordinal value itself) * Throw an IllegalArgumentException if there are too many enum members. For example,

Re: Adding support for EnumSet to ByteBuffer

2007-06-10 Thread Trustin Lee
On 6/10/07, peter royal <[EMAIL PROTECTED]> wrote: On Jun 8, 2007, at 11:03 PM, Mike Heath wrote: > If this functionality is desired, I'll add some Java Docs to the above > methods and commit my code and accompanying unit tests. very nice! looks to be a very useful addition! Indeed. I'd like t

Re: Adding support for EnumSet to ByteBuffer

2007-06-09 Thread peter royal
On Jun 8, 2007, at 11:03 PM, Mike Heath wrote: If this functionality is desired, I'll add some Java Docs to the above methods and commit my code and accompanying unit tests. very nice! looks to be a very useful addition! -pete -- [EMAIL PROTECTED] - http://fotap.org/~osi smime.p7s Descr

Adding support for EnumSet to ByteBuffer

2007-06-08 Thread Mike Heath
I've been twiddling a lot of bits with MINA and got tired of it so I created a utility class that converts instances of EnumSet to bit vectors and vice-versa. I thought this feature would be a good addition to MINA's ByteBuffer. Instead of just committing the change, I wanted to run the idea past