Re: Review DIRMINA-994

2014-11-07 Thread Jeff MAURY
Le Fri Nov 07 2014 at 07:57:09, Emmanuel Lécharny elecha...@gmail.com a écrit : Le 07/11/14 07:30, Jeff MAURY a écrit : Le Fri Nov 07 2014 at 1:42:43 AM, Emmanuel Lécharny elecha...@gmail.com a écrit : Le 06/11/14 23:15, Jeff MAURY a écrit : Hello, upon Emmanuel's request, I

Re: Review DIRMINA-994

2014-11-07 Thread Emmanuel Lécharny
Le 07/11/14 12:06, Jeff MAURY a écrit : Le Fri Nov 07 2014 at 07:57:09, Emmanuel Lécharny elecha...@gmail.com a écrit : I'm just stating the fact that when future were introduced, we weren't using generic yet, because we wanted to keep the 1.4 compatibility. When we decided to switch to

Review DIRMINA-994

2014-11-06 Thread Jeff MAURY
Hello, upon Emmanuel's request, I reviewed the fix for DIRMINA-994 (commit f1972fc3de8c4074ff7b60f8c557d3c53013e30b). Here are my remarks: - the Future framework in MINA2 is not linked in any form to JDK's Future, is there any reason for that ? I've seen that IOFuture in MINA3 extends

Re: Review DIRMINA-994

2014-11-06 Thread Emmanuel Lécharny
Le 06/11/14 23:15, Jeff MAURY a écrit : Hello, upon Emmanuel's request, I reviewed the fix for DIRMINA-994 (commit f1972fc3de8c4074ff7b60f8c557d3c53013e30b). Here are my remarks: - the Future framework in MINA2 is not linked in any form to JDK's Future, is there any reason for that ?

Re: Review DIRMINA-994

2014-11-06 Thread Jeff MAURY
Le Fri Nov 07 2014 at 1:42:43 AM, Emmanuel Lécharny elecha...@gmail.com a écrit : Le 06/11/14 23:15, Jeff MAURY a écrit : Hello, upon Emmanuel's request, I reviewed the fix for DIRMINA-994 (commit f1972fc3de8c4074ff7b60f8c557d3c53013e30b). Here are my remarks: - the Future

Re: Review DIRMINA-994

2014-11-06 Thread Emmanuel Lécharny
Le 07/11/14 07:30, Jeff MAURY a écrit : Le Fri Nov 07 2014 at 1:42:43 AM, Emmanuel Lécharny elecha...@gmail.com a écrit : Le 06/11/14 23:15, Jeff MAURY a écrit : Hello, upon Emmanuel's request, I reviewed the fix for DIRMINA-994 (commit f1972fc3de8c4074ff7b60f8c557d3c53013e30b). Here are