Re: svn commit: r942690 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/impl/FtpIoSession.java test/java/org/apache/ftpserver/clienttests/LoginTest.java

2010-05-10 Thread Niklas Gustavsson
On Mon, May 10, 2010 at 2:19 PM, Sai Pullabhotla wrote: > +1 for this. Most of the code that is currently checked is not > formatted using the published formatter. It should be easy to reformat > all the sources and check them in. Agreed. /niklas

Re: svn commit: r942690 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/impl/FtpIoSession.java test/java/org/apache/ftpserver/clienttests/LoginTest.java

2010-05-10 Thread Sai Pullabhotla
+1 for this. Most of the code that is currently checked is not formatted using the published formatter. It should be easy to reformat all the sources and check them in. Regards, Sai Pullabhotla On Mon, May 10, 2010 at 4:45 AM, Emmanuel Lecharny wrote: > On 5/10/10 11:41 AM, David Latorre wro

Re: svn commit: r942690 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/impl/FtpIoSession.java test/java/org/apache/ftpserver/clienttests/LoginTest.java

2010-05-10 Thread Niklas Gustavsson
On Mon, May 10, 2010 at 12:20 PM, David Latorre wrote: > So, what do you want me to do Niklas? I got a new file with only the > code changes ... should I commit this? For it would show a lot of > differences with the previous file as well, or do you just want the > patch file in order to see the d

Re: svn commit: r942690 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/impl/FtpIoSession.java test/java/org/apache/ftpserver/clienttests/LoginTest.java

2010-05-10 Thread David Latorre
So, what do you want me to do Niklas? I got a new file with only the code changes ... should I commit this? For it would show a lot of differences with the previous file as well, or do you just want the patch file in order to see the differences... Btw I used winmerge to generate the patch file a

Re: svn commit: r942690 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/impl/FtpIoSession.java test/java/org/apache/ftpserver/clienttests/LoginTest.java

2010-05-10 Thread Emmanuel Lecharny
On 5/10/10 11:41 AM, David Latorre wrote: Oh sorry, I believed I was using "MINA formatter" so I thought it would be ok to format the whole thing. It would be a good idea to "reformat" all the files following the current formater in one big commit, so that developpers are not annoyed when

Re: svn commit: r942690 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/impl/FtpIoSession.java test/java/org/apache/ftpserver/clienttests/LoginTest.java

2010-05-10 Thread David Latorre
Oh sorry, I believed I was using "MINA formatter" so I thought it would be ok to format the whole thing. Let me check if this happened for both commits and i'll fix the issue. 2010/5/10 Niklas Gustavsson : > On Mon, May 10, 2010 at 11:03 AM,   wrote: >> Author: dlat >> Date: Mon May 10 09:03:0

Re: svn commit: r942690 - in /mina/ftpserver/trunk/core/src: main/java/org/apache/ftpserver/impl/FtpIoSession.java test/java/org/apache/ftpserver/clienttests/LoginTest.java

2010-05-10 Thread Niklas Gustavsson
On Mon, May 10, 2010 at 11:03 AM, wrote: > Author: dlat > Date: Mon May 10 09:03:00 2010 > New Revision: 942690 > > URL: http://svn.apache.org/viewvc?rev=942690&view=rev > Log: > FTPSERVER-369 maxLogin is reached immediately. REIN command is not decreasing > the login count. There's a lot of fo