[jira] Closed: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-06-27 Thread Julien Vermillard (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Vermillard closed DIRMINA-529. - > use isPrimitive() instead of comparing the string to a list of primiti

[jira] Updated: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-03-16 Thread Trustin Lee (JIRA)
;t find any difference. So far, isPrimitive() seems to ourperform all alternatives. I'm on Linux with SUN JDK 1.6.0_05 Server VM. > use isPrimitive() instead of comparing the string to a list of primitives > - &

[jira] Issue Comment Edited: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-03-12 Thread JIRA
the extended and slightly altered benchmark. > use isPrimitive() instead of comparing the string to a list of primitives > - > > Key: DIRMINA-529 > URL: https://issues.apache.org/

[jira] Commented: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-03-12 Thread JIRA
name=Windows Vista true Not sure why this is the case. Any ideas? Will try to attach my the extended and slightly altered benchmark. > use isPrimitive() instead of comparing the string to a list of pri

[jira] Updated: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-03-12 Thread JIRA
[ https://issues.apache.org/jira/browse/DIRMINA-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johannes Ulfkjær Jensen updated DIRMINA-529: Attachment: Primitive.java > use isPrimitive() instead of comparing

[jira] Updated: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-03-12 Thread Edouard De Oliveira (JIRA)
. Ran under jdk1.6.0_3, output is : Elapsed method 1 = 531 Elapsed method 2 = 1297 > use isPrimitive() instead of comparing the string to a list of primitives > - > > Key: DIRMINA-529 >

[jira] Commented: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-03-11 Thread Trustin Lee (JIRA)
ower than if - else if - ... block. Any benchmark report is appreciated. > use isPrimitive() instead of comparing the string to a list of primitives > - > > Key: DIRMINA-529 >

[jira] Resolved: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-03-11 Thread Trustin Lee (JIRA)
trunk. > use isPrimitive() instead of comparing the string to a list of primitives > - > > Key: DIRMINA-529 > URL: https://issues.apache.org/jira/browse/DIRMINA-529 >

[jira] Updated: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-03-06 Thread Mike Heath (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Heath updated DIRMINA-529: --- Fix Version/s: 2.0.0-M2 > use isPrimitive() instead of comparing the string to a list of primiti

[jira] Commented: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-02-10 Thread JIRA
tive call, and being pure java, I think (pure speculation) that the JIT would have an easier time compiling it. This is obviously just an extreme mini optimization (compared to the patch) but I thought I would chime in regardless :) > use isPrimitive() instead of comparing the string to a

Re: use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Stivo
There is a first time for everything :) I did, https://issues.apache.org/jira/browse/DIRMINA-529 Greetz, Stivo Maarten Bosteels wrote: > > Could you create a JIRA ticket and attach your patch to it ? > And don't forget to click the radio button that says > 'Grant license to ASF for inclusion

[jira] Updated: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Stefan Ackermann (JIRA)
class is primitive instead of comparing to a list of known primitive class names (was: Never done this before, will try to attach the patch) > use isPrimitive() instead of comparing the string to a list of primiti

[jira] Updated: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Stefan Ackermann (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Ackermann updated DIRMINA-529: - Attachment: mina-patch.txt > use isPrimitive() instead of comparing the string t

[jira] Created: (DIRMINA-529) use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Stefan Ackermann (JIRA)
use isPrimitive() instead of comparing the string to a list of primitives - Key: DIRMINA-529 URL: https://issues.apache.org/jira/browse/DIRMINA-529 Project: MINA Issue

Re: use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Maarten Bosteels
Could you create a JIRA ticket and attach your patch to it ? And don't forget to click the radio button that says 'Grant license to ASF for inclusion in ASF works (as per the Apache Software License §5)' Thanks Maarten On Feb 7, 2008 10:25 AM, Maarten Bosteels <[EMAIL PROTECTED]> wrote: > Hi Sti

Re: use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Maarten Bosteels
Hi Stivo, Thanks for the patch ! I will have a look at it. Maarten On Feb 7, 2008 9:56 AM, Stivo <[EMAIL PROTECTED]> wrote: > > I figured out how to make a patch so here goes. > I ran the maven test with it, and it ran fine. > > Index: C:/Users/Stivo/workspacenew/mina > trunk/core/src/main/java

Re: use isPrimitive() instead of comparing the string to a list of primitives

2008-02-07 Thread Stivo
I figured out how to make a patch so here goes. I ran the maven test with it, and it ran fine. Index: C:/Users/Stivo/workspacenew/mina trunk/core/src/main/java/org/apache/mina/common/IoBuffer.java === --- C:/Users/Stivo/workspacenew/

use isPrimitive() instead of comparing the string to a list of primitives

2008-02-04 Thread Stefan Ackermann
Hi This is not really a problem, but I noticed that on line 1612 of AbstractIOBuffer in the current trunk determining whether a class is primitive could be done nicer and faster with this: Replace: String className = desc.getName(); if (primitiveTypeNa