Re: [Discussion] Recognise Reviewers, Besides Committers and PMC

2018-10-21 Thread YiZhi Liu
+1 I also suggest add reviewer list link to the PR template, so that developers can easily request review from those reviewers. On Sun, Oct 21, 2018 at 8:30 PM Tianqi Chen wrote: > > I was suggesting something more concrete: > > - Add a Reviewers section to > https://github.com/apache/incubator-mx

Re: [Discussion] PMC and Committer Courtesy: Only Propose Candidate in a Different Organization

2018-10-21 Thread Naveen Swamy
this suggestion looks like it is putting the onus on contributors to collaborate with contributors outside their org to get nominated to be committer or a PMC of this project. Every organization has its own business goals, on the way to meet their objectives if their employees happen to be great co

Re: [Discussion] Recognise Reviewers, Besides Committers and PMC

2018-10-21 Thread Tianqi Chen
I was suggesting something more concrete: - Add a Reviewers section to https://github.com/apache/incubator-mxnet/blob/master/CONTRIBUTORS.md to list a list of Reviewers. - This is a "pesudo role", but holds weight as committers should highly value their reviews during the PR process. - The com

Re: [Discussion] PMC and Committer Courtesy: Only Propose Candidate in a Different Organization

2018-10-21 Thread Tianqi Chen
> > Many potential committers and > PMC won’t interact with the non-Amazonians at all (since there are so few), > so they’d be relegated to obscurity and hopelessness by default. > If potential contributors do not comes from Amazon, then the Amazonian PMC can nominate them :) If the potential co

Re: [Discussion] Separating PMC and Committership

2018-10-21 Thread Chris Olivier
I am ok with this current doc. The other doc, I forget where it is, has a list something like “things that will make you a committerpushing a release out” (or something like that). Which isn’t really the case, since lots of people who have led a release aren’t committers yet. On Thu, Oct 18, 2

Re: [Discussion] PMC and Committer Courtesy: Only Propose Candidate in a Different Organization

2018-10-21 Thread Chris Olivier
-1 There’s too few non-Amazonians for this to be fair IMHO. While I am in strong favor of more non-Amazonians being part of the community, making a rule (or guideline) like this would put a very small group of people in control of the PMC. In addition, that “day job” line is a bit gray in areas,

Re: [Discussion] Recognise Reviewers, Besides Committers and PMC

2018-10-21 Thread Steffen Rochel
+1 With the release announcement for MXNet 1.3 all contributors incl. code reviewers have been recognized. I suggest all future release announcements should include such recognition. Are you suggesting to highlight most active reviewers in release announcement or regularly (e.g. monthly), specifica

Re: [Discussion] PMC and Committer Courtesy: Only Propose Candidate in a Different Organization

2018-10-21 Thread Steffen Rochel
Hi Tianqi - +1 . I like the idea to grow diversity at the project and encourage communication beyond people sitting next to each other. I also support the way you described as guideline, not has a hard rule. I think it is important we focus on merit and contributions when evaluating nominee for com

[Discussion] PMC and Committer Courtesy: Only Propose Candidate in a Different Organization

2018-10-21 Thread Tianqi Chen
Dear MXNet Community: There has been a great discussion going on in terms of PMC/Committer Criteria. As a community move forward, it is important to make the community inclusive to everyone and encourage folks to work together. I want to propose the following proposal courtesy: when a PMC propos

Re: [Discussion] Recognise Reviewers, Besides Committers and PMC

2018-10-21 Thread Tianqi Chen
Also re another email-thread(I sent out one with my institutional email which get blocked initially, so this one was a bit duplication of that). I think it should really be the job of committers to recognize potential reviewers, github also makes it easier to do so, e.g. https://github.com/apache/i